Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Recursive election provider as fallback #9648

Merged
14 commits merged into from
Sep 12, 2021
Merged

Recursive election provider as fallback #9648

14 commits merged into from
Sep 12, 2021

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Aug 29, 2021

Another simpler attempt at #8573. No logic change, just simpler API. Also something that I am implementing in the new election pallets as a part of paritytech/polkadot-sdk#461, so it needed to be backported.

polkadot companion: paritytech/polkadot#3757

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 29, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kianenigma
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 10, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 10, 2021

Merge aborted: Checks failed for b048c85

@kianenigma
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 12, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 12, 2021

Merge failed: "Required status check "continuous-integration/gitlab-check-polkadot-companion-build" is failing."

@kianenigma
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 12, 2021

Trying merge.

@ghost ghost merged commit 2ec7f55 into master Sep 12, 2021
@ghost ghost deleted the kiz-recursive-fallback-2 branch September 12, 2021 14:38
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants