This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Generate storage info for pallet im_online #9654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
suggested changes
Aug 31, 2021
gui1117
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Aug 31, 2021
gui1117
reviewed
Sep 7, 2021
gui1117
reviewed
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from this last note, I think it should be good to me
gui1117
reviewed
Sep 14, 2021
gui1117
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, maybe name can be improved slightly
gui1117
added
A0-please_review
Pull request needs code review.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Sep 14, 2021
KiChjang
reviewed
Sep 18, 2021
KiChjang
reviewed
Sep 18, 2021
KiChjang
reviewed
Sep 18, 2021
KiChjang
approved these changes
Sep 19, 2021
CI is complaining:
|
Changing some `Vec` to `WeakBoundedVec` Adding the following bounds: * `MaxKeys * `MaxPeerInHeartbeats` * `MaxPeerDataEncodingSize` to limit the size of `WeakBoundedVec`
Rebased my branch to make it cleaner and force the checks of the polkadot companion |
gui1117
added
B3-apinoteworthy
and removed
B0-silent
Changes should not be mentioned in any release notes
labels
Sep 20, 2021
bot merge |
Waiting for commit status. |
Merge failed: "Required status check "check-labels" is in progress." |
bot merge |
Trying merge. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of paritytech/polkadot-sdk#323
Refactor Im Online to use WeakBoundedVec instead of Vec, and generate storage info for that pallet.
polkadot companion: paritytech/polkadot#3744
@shawntabrizi @KiChjang @thiolliere