Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chore: refresh of the substrate_builder image #9808

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 17, 2021

This PR is a refresher for the Substrate Docker image.
It adds missing labels and a build script.

It is important to notice (readme) a few things:

  • unlike the polkadot image where polkadot is the only binary and the entrypoint, this substrate image contains several binaries and the binary you want to use needs to be provided (there is no default entrypoint).
  • the image contains no other binaries than those we built, so you won't be able to run bash, curl, etc...

fix #9765

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 17, 2021
@chevdor chevdor marked this pull request as ready for review September 29, 2021 09:07
@chevdor chevdor requested a review from a team as a code owner September 29, 2021 09:07
Copy link
Contributor

@alvicsam alvicsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

docker/substrate_builder.Dockerfile Outdated Show resolved Hide resolved
@chevdor chevdor merged commit ddc2c6e into master Oct 4, 2021
@chevdor chevdor deleted the wk-docker-9765 branch October 4, 2021 19:19
ordian added a commit that referenced this pull request Oct 5, 2021
* master: (125 commits)
  Update multiple dependencies (#9936)
  Speed up timestamp generation when logging (#9933)
  First word should be Substrate not Polkadot (#9935)
  Improved file not found error message (#9931)
  don't read events in elections anymore. (#9898)
  Remove incorrect sanity check (#9924)
  Require crypto scheme for `insert-key` (#9909)
  chore: refresh of the substrate_builder image (#9808)
  Introduce block authorship soft deadline (#9663)
  Rework Transaction Priority calculation (#9834)
  Do not propagate host RUSTFLAGS when checking for WASM toolchain (#9926)
  Small quoting comment fix (#9927)
  add clippy to CI (#9694)
  Ensure BeforeBestBlockBy voting rule accounts for base (#9920)
  rm `.maintain` lock (#9919)
  Downstream `node-template` pull (#9915)
  Implement core::fmt::Debug for BoundedVec (#9914)
  Quickly skip invalid transactions during block authorship. (#9789)
  Add SS58 prefix for Automata (#9805)
  Clean up sc-peerset (#9806)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .maintain/Dockerfile
4 participants