chore(deps): Update smoldot to the latest version #1400

lexnv · 2024-01-26T13:09:04Z

This PR updates smoldot to 0.17 and smoldot-light to 0.15.

Changes to repo:

AddedChain now receives a generic PlatformRef trait to accommodate smoldot changes

Pending fix from:

chain_subscribeFinalizedHeads subscription seems to not produce blocks smol-dot/smoldot#1638

Status Update 8 July

Smoldot is now producing blocks with the legacy RPCS
The latest version has a regression in syncing from 30seconds to 175seconds
This means we are producing blocks, but the distance between the first finalized block (the block presented in the chainSpec) and the second finalized block is now 175seconds (until grandpa warp sync completes)

Pending fix:

Warp sync regression for smoldot v0.18 smol-dot/smoldot#1896

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

jsdw · 2024-01-31T09:22:19Z

testing/integration-tests/src/light_client/mod.rs

+    // non_finalized_headers_subscription(&api).await?;
    finalized_headers_subscription(&api).await?;
-    runtime_api_call(&api).await?;
-    storage_plain_lookup(&api).await?;
-    dynamic_constant_query(&api).await?;
-    dynamic_events(&api).await?;
+    // runtime_api_call(&api).await?;
+    // storage_plain_lookup(&api).await?;
+    // dynamic_constant_query(&api).await?;
+    // dynamic_events(&api).await?;


Should these still be commented out?

Yep, I've added a few debug logs in f14bf9a.
This is to help reproduce the issue from smoldot faster smol-dot/smoldot#1638.

I suggest putting this PR on pending until another smoldot version is published on crates io :D

Sounds like a plan :)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

size This reverts commit 74dd9d7. Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 · 2024-09-03T15:30:08Z

lightclient/src/background.rs

+fn trim_response(response: &str) -> &str {
+    const MAX_RESPONSE_SIZE: usize = 256;
+    let len = std::cmp::min(response.len(), MAX_RESPONSE_SIZE);
+    &response[..len]


nit, you could actually index into non-char boundary here because not all chars are ascii which leads to a panic..

https://github.com/paritytech/jsonrpsee/blob/master/core/src/tracing.rs#L101-#L124

There are a couple of nightly only methods that would be perfect here, but in the absense of them one could do:

while !response.is_char_boundary(len) { len -= 1; } &response[..len]

To find the appropriate place to slice a message that exceeds the length

I've ended up with something similar to Niklas's suggestion, I found that a bit easier to follow :D

jsdw · 2024-09-04T10:19:34Z

lightclient/src/background.rs

+                    let (maybe_truncated, delim) = if back_message.len() > MAX_LOG_SIZE {
+                        (&back_message[0..MAX_LOG_SIZE], "...")
+                    } else {
+                        (&back_message[..], "")
+                    };


Do we need to worry about invalid UTF boundaries here too?

(should trim_repsonse take in a max length and then it can be used here too?)

jsdw · 2024-09-04T10:23:45Z

testing/integration-tests/src/light_client/mod.rs

+/// Use the unstable backend for testing.
+const USE_UNSTABLE_BACKEND: bool = true;


I guess it makes sense to test the light client with just the "unstable" backend, though we could have that light client test be a fn that takes in this bool and then run it twice to test both backends until the unstable one is stabilised? (and then remove this const)

jsdw

Couple of small nits but looks great to me; thanks for doing this!

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Cargo.toml

niklasad1

🚀

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>

testing/integration-tests/src/light_client/mod.rs

lexnv added 3 commits January 26, 2024 14:56

Update smoldot to 0.17 and smoldot-light to 0.15

bf3c7f3

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Update cargo lock

1231920

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Add generic platform for AddedChain

ab0f67f

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv requested a review from a team as a code owner January 26, 2024 13:09

niklasad1 approved these changes Jan 26, 2024

View reviewed changes

lexnv mentioned this pull request Jan 26, 2024

LightClient: Unsubscribe from subscriptions to avoid warnings #1402

Closed

lexnv added 2 commits January 30, 2024 14:25

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

b948044

debug: Finalized heads

f14bf9a

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv mentioned this pull request Jan 30, 2024

chain_subscribeFinalizedHeads subscription seems to not produce blocks smol-dot/smoldot#1638

Closed

jsdw reviewed Jan 31, 2024

View reviewed changes

niklasad1 self-requested a review January 31, 2024 09:26

lexnv changed the title ~~chore(deps): Update smoldot to the latest version~~ [pending fix] chore(deps): Update smoldot to the latest version Jan 31, 2024

lexnv added 3 commits April 3, 2024 19:05

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

644626f

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Use generic TPlat for chainSuccess

b91742a

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Trim response for logs

75ace42

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv mentioned this pull request Apr 3, 2024

testing: Prepare light client testing with substrate binary and add subxt-test macro #1507

Merged

lexnv added 14 commits April 8, 2024 10:56

Backup

c8020c9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

6c9088e

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

tests/lightclient: Switch to localnode for testing

74dd9d7

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

cargo: Point smoldot to crates.io

1c96d5e

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

03c629a

Solve merge conflicts

1de5a06

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Add subxt macro for tests

c74e4ad

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient/wasm: Impl log of the PlatformRef

b517adf

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Use git dep

67ca3ec

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

c776229

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Revert "tests/lightclient: Switch to localnode for testing" + max log

c4fe110

size This reverts commit 74dd9d7. Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

tests: Comment chainspec

6cca6f9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient/wasm: Import IpAddr from core::net

2e7bacd

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

c587309

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

cargo: Use released smoldot version

2779faf

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv changed the title ~~[pending fix] chore(deps): Update smoldot to the latest version~~ chore(deps): Update smoldot to the latest version Jun 26, 2024

lexnv mentioned this pull request Jul 1, 2024

Warp sync regression for smoldot v0.18 smol-dot/smoldot#1896

Open

lexnv added 3 commits September 3, 2024 14:44

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

4612da3

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Use chainspec and optionally make use of unstable backend

648b4f9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Fix clippy

3b81de0

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 reviewed Sep 3, 2024

View reviewed changes

niklasad1 self-requested a review September 4, 2024 07:41

jsdw reviewed Sep 4, 2024

View reviewed changes

jsdw approved these changes Sep 4, 2024

View reviewed changes

lexnv added 2 commits September 6, 2024 13:26

lightclient: Better trimming for log messages

b69cba7

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Remove max log size

f222db1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 reviewed Sep 6, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

niklasad1 reviewed Sep 6, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

niklasad1 approved these changes Sep 6, 2024

View reviewed changes

lexnv and others added 5 commits September 6, 2024 13:39

lightclient: Use both backends for testing

1a02662

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Update Cargo.toml

f3c6179

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>

Update Cargo.toml

8b34dcd

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>

Merge remote-tracking branch 'origin/master' into lexnv/update-smoldot

30c81b8

Merge branch 'master' into lexnv/update-smoldot

7a41bf7

niklasad1 reviewed Sep 6, 2024

View reviewed changes

testing/integration-tests/src/light_client/mod.rs Outdated Show resolved Hide resolved

Update testing/integration-tests/src/light_client/mod.rs

0b611f5

niklasad1 reviewed Sep 6, 2024

View reviewed changes

testing/integration-tests/src/light_client/mod.rs Show resolved Hide resolved

Update testing/integration-tests/src/light_client/mod.rs

43bd4db

lexnv merged commit 1cf206f into master Sep 9, 2024
13 checks passed

lexnv deleted the lexnv/update-smoldot branch September 9, 2024 07:30

niklasad1 mentioned this pull request Sep 9, 2024

unstable backend incompatible with smoldot v0.18: chainHead API doesn't work #1749

Closed

niklasad1 mentioned this pull request Oct 3, 2024

Update smoldot dependency #1188

Closed

jsdw mentioned this pull request Oct 24, 2024

Prep to release v0.38.0 #1841

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Update smoldot to the latest version #1400

chore(deps): Update smoldot to the latest version #1400

lexnv commented Jan 26, 2024 •

edited

Loading

jsdw Jan 31, 2024

lexnv Jan 31, 2024

jsdw Feb 1, 2024

niklasad1 Sep 3, 2024

jsdw Sep 4, 2024 •

edited

Loading

lexnv Sep 6, 2024

jsdw Sep 4, 2024 •

edited

Loading

jsdw Sep 4, 2024

jsdw left a comment

niklasad1 left a comment

		/// Use the unstable backend for testing.
		const USE_UNSTABLE_BACKEND: bool = true;

chore(deps): Update smoldot to the latest version #1400

chore(deps): Update smoldot to the latest version #1400

Conversation

lexnv commented Jan 26, 2024 • edited Loading

Status Update 8 July

jsdw Jan 31, 2024

Choose a reason for hiding this comment

lexnv Jan 31, 2024

Choose a reason for hiding this comment

jsdw Feb 1, 2024

Choose a reason for hiding this comment

niklasad1 Sep 3, 2024

Choose a reason for hiding this comment

jsdw Sep 4, 2024 • edited Loading

Choose a reason for hiding this comment

lexnv Sep 6, 2024

Choose a reason for hiding this comment

jsdw Sep 4, 2024 • edited Loading

Choose a reason for hiding this comment

jsdw Sep 4, 2024

Choose a reason for hiding this comment

jsdw left a comment

Choose a reason for hiding this comment

niklasad1 left a comment

Choose a reason for hiding this comment

lexnv commented Jan 26, 2024 •

edited

Loading

jsdw Sep 4, 2024 •

edited

Loading

jsdw Sep 4, 2024 •

edited

Loading