Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update substrate and hardcoded default ChargeAssetTxPayment extension #330

Merged
merged 4 commits into from
Nov 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/extrinsic/extra.rs
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,16 @@ where
/// in the queue.
#[derive(Encode, Decode, Clone, Eq, PartialEq, Debug, TypeInfo)]
#[scale_info(skip_type_params(T))]
pub struct ChargeTransactionPayment(#[codec(compact)] pub u128);
pub struct ChargeAssetTxPayment {
/// The tip for the block author.
#[codec(compact)]
pub tip: u128,
/// The asset with which to pay the tip.
pub asset_id: Option<u32>,
}

impl SignedExtension for ChargeTransactionPayment {
const IDENTIFIER: &'static str = "ChargeTransactionPayment";
impl SignedExtension for ChargeAssetTxPayment {
const IDENTIFIER: &'static str = "ChargeAssetTxPayment";
type AccountId = u64;
type Call = ();
type AdditionalSigned = ();
Expand Down Expand Up @@ -264,7 +270,7 @@ impl<T: Config + Clone + Debug + Eq + Send + Sync> SignedExtra<T> for DefaultExt
CheckMortality<T>,
CheckNonce<T>,
CheckWeight<T>,
ChargeTransactionPayment,
ChargeAssetTxPayment,
);
type Parameters = ();

Expand All @@ -291,7 +297,10 @@ impl<T: Config + Clone + Debug + Eq + Send + Sync> SignedExtra<T> for DefaultExt
CheckMortality((Era::Immortal, PhantomData), self.genesis_hash),
CheckNonce(self.nonce),
CheckWeight(PhantomData),
ChargeTransactionPayment(u128::default()),
ChargeAssetTxPayment {
tip: u128::default(),
asset_id: None,
},
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/extrinsic/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ mod signer;

pub use self::{
extra::{
ChargeTransactionPayment,
ChargeAssetTxPayment,
CheckGenesis,
CheckMortality,
CheckNonce,
Expand Down
16 changes: 10 additions & 6 deletions tests/integration/frame/balances.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ async fn tx_basic_transfer() {
.expect("Failed to decode ExtrinisicSuccess")
.expect("Failed to find ExtrinisicSuccess");

let expected_event = balances::events::Transfer(
alice.account_id().clone(),
bob.account_id().clone(),
10_000,
);
let expected_event = balances::events::Transfer {
from: alice.account_id().clone(),
to: bob.account_id().clone(),
amount: 10_000,
};
assert_eq!(event, expected_event);

let alice_post = api
Expand Down Expand Up @@ -215,7 +215,11 @@ async fn transfer_subscription() {
let event = balances::events::Transfer::decode(&mut &raw.data[..]).unwrap();
assert_eq!(
event,
balances::events::Transfer(alice.account_id().clone(), bob.clone(), 10_000,)
balances::events::Transfer {
from: alice.account_id().clone(),
to: bob.clone(),
amount: 10_000
}
);
}

Expand Down
Binary file modified tests/integration/node_runtime.scale
Binary file not shown.