add constants api to codegen #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
constants-api
branch
from
7d92051 to
5fc7362
Compare
jsdw
reviewed
Jan 21, 2022
|
Offhand I'm happy with this approach; it looks fairly clean and I like the api that you end up with! |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
constants-api
branch
from
4a21524 to
a93396a
Compare
ascjones
approved these changes
Jan 26, 2022
ascjones
reviewed
Jan 26, 2022
jsdw
reviewed
Jan 27, 2022
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
jsdw
approved these changes
Jan 27, 2022
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* add constants api to codegen Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * handle constant decoding error Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * fix clippy and remove extra constants allocation Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Closes #396