[WIP]: jsonrpsee proc macros #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-jsonrpsee-core-client
jsdw
reviewed
Feb 11, 2022
niklasad1
force-pushed
the
na-jsonrpsee-macros
branch
from
073e6da to
5ee0bb5
Compare
|
Just to note; it seems likely that the plan will be to abstract over Rpc clients more, see #596. So perhaps we don't want to commit to using generated jsonrpsee types too much? |
|
yeah, let's close this PR It works now thanks to Alex's traits bound overrides but doesn't make things better for subxt anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see if it's possible to get rid of those annoying required type params.