Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modified types to support new ChargeAssetTxPayment #340

Merged
merged 10 commits into from
Dec 18, 2023
Merged

feat: modified types to support new ChargeAssetTxPayment #340

merged 10 commits into from
Dec 18, 2023

Conversation

bee344
Copy link
Collaborator

@bee344 bee344 commented Nov 21, 2023

Closes #325

@bee344 bee344 requested a review from a team as a code owner November 21, 2023 22:56
@bee344 bee344 changed the title feat: modified types to use new ChargeAssetTxPayment feat: modified types to use new ChargeAssetTxPayment [WIP] Nov 21, 2023
TarikGul
TarikGul approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit and question. Other than that the PR looks amazing! Thanks :)

@bee344
Copy link
Collaborator Author

bee344 commented Nov 21, 2023

Heads up, this depends on this PJS PR to be merged.

@nuel77 nuel77 mentioned this pull request Dec 7, 2023
Closed
marshacb
marshacb approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bee344 bee344 changed the title feat: modified types to use new ChargeAssetTxPayment [WIP] feat: modified types to support new ChargeAssetTxPayment Dec 18, 2023
@bee344 bee344 merged commit fb79142 into main Dec 18, 2023
8 checks passed
@bee344 bee344 deleted the anp-asset-conversion branch December 18, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@marshacb marshacb marshacb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MutliLocation versioned types to assetId for signed extension types
3 participants
@bee344 @marshacb @TarikGul