chainSpec: support for injecting paras into RuntimeGenesisConfigPatch #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
requested review from
pepoviola,
wirednkod and
l0r1s
as code owners
wirednkod
reviewed
Sep 1, 2023
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
michalkucharczyk
commented
Sep 1, 2023
michalkucharczyk
commented
Sep 1, 2023
|
All zombienet tests are green in paritytech/polkadot-sdk#1256: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines/386286 |
pepoviola
approved these changes
Sep 2, 2023
Awesome, I can merge it and include in the next release if you are agree. |
wirednkod
approved these changes
Sep 4, 2023
Would be great to have it in official version. It is backward compatible so should be safe. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes two fixes for manipulating
chainSpec, which are required for paritytech/polkadot-sdk#1256:runtime_genesis_configfield is no longer part of RuntimeGenesisConfig for rococo runtimes. It was removed inchain-spec: getting ready for native-runtime-free world polkadot-sdk#1256, instead of this unifiedRuntimeGenesisConfigPatchfield is available.RuntimeGenesisConfigpatch contained inChainSpecdoes not contain any default values for runtime genesis config. It only contains values that were overwritten by chain spec author. Since thepara.parawas not changed in rococo chain spec it is not contained in patch. We need to inject it.For more info on
RuntimeGenesisConfigPatchplease refer to paritytech/polkadot-sdk#1256.Step towards: paritytech/polkadot-sdk#25