Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker desktop extension bug fixes and improvements #222

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

danleyb2
Copy link
Collaborator

@danleyb2 danleyb2 commented Nov 4, 2024

  • Bug, port not showing in command when using default restart policy
  • Show more descriptive error message when Run command fails
  • Move loader from top into the button when you click "Show Command"

Summary by CodeRabbit

  • Style: Updated the Loader component styling in the UI for improved visual consistency.
  • Refactor: Enhanced user experience by moving the loader into the submit button in both Snapshot and Stream components, providing contextual loading feedback during form submissions.
  • Bug Fix: Improved error messaging in the ShowCommand component by including detailed standard error output, offering users more informative feedback on command execution failures.

Copy link

github-actions bot commented Nov 4, 2024

Image description CodeRabbit

Walkthrough

The updates enhance user experience by refining UI components in a React application. Key changes include improved loading indicators within buttons for contextual feedback, updated error messages for better clarity, and dependency adjustments in hooks to ensure accurate state management.

Changes

Files Summary
docker/dd-extension/ui/src/components/Loader.tsx Added a new styling class (me-1) to the Spinner component for improved UI appearance.
docker/dd-extension/ui/src/components/Snapshot.tsx, docker/dd-extension/ui/src/components/Stream.tsx Moved the Loader component into the submit button for more contextual loading feedback during form submission. Updated useEffect dependencies in Snapshot.tsx.
docker/dd-extension/ui/src/components/ShowCommand.tsx Enhanced error message to include standard error output for better debugging information when a command fails.

In code's garden, changes bloom,
Loaders shift to buttons' room.
Errors now with clearer sight,
Ports align, dependencies right.
A rabbit hops through lines of lore,
Making apps a joy to explore. 🌟🐇


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 7645a7f and 7742696 commits.
Files selected (4)
  • docker/dd-extension/ui/src/components/Loader.tsx (1)
  • docker/dd-extension/ui/src/components/ShowCommand.tsx (1)
  • docker/dd-extension/ui/src/components/Snapshot.tsx (4)
  • docker/dd-extension/ui/src/components/Stream.tsx (2)
Files skipped from review due to trivial changes (1)
  • docker/dd-extension/ui/src/components/Loader.tsx
Review comments generated (6)
  • Review: 1
  • LGTM: 5

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

docker/dd-extension/ui/src/components/ShowCommand.tsx Outdated Show resolved Hide resolved
@marcbelmont marcbelmont requested a review from Pefington November 4, 2024 12:33
@marcbelmont marcbelmont merged commit 3f881a7 into master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants