-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add verbose logs on every response #226
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce logging to various functions across multiple files, replacing print statements with structured logging. This enhances traceability by including vehicle details in logs and ensures consistent error and success message handling without altering the external behavior or interfaces of the code. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (6)
- webhooks/middleware/protocols/crop_plate.py (3)
- webhooks/middleware/protocols/nx.py (1)
- webhooks/middleware/protocols/openeye.py (2)
- webhooks/middleware/protocols/salient.py (2)
- webhooks/middleware/protocols/soap.py (2)
- webhooks/middleware/protocols/synology_rest.py (3)
Files skipped from review due to trivial changes (1)
- webhooks/middleware/protocols/nx.py
Review comments generated (8)
- Review: 5
- LGTM: 3
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
@adolfoarmas please review and test. |
Summary by CodeRabbit
process_request
functions across multiple protocols for improved error tracking and information logging.nx.py
andsalient.py
to include vehicle details, improving traceability of requests.forward_to_SOAP_service
function insoap.py
, providing detailed logs on SOAP request outcomes.