New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First release #1

Merged

jordigilh merged 51 commits into main from first_release

Apr 1, 2024

Collaborator

jordigilh commented Mar 20, 2024

First release of the helm operator temporally aligned to chart version in this PR
parodos-dev/orchestrator-helm-chart#111

Uses a custom helm operator container image that includes this PR
operator-framework/operator-sdk#6691
which is needed to ensure that the dry-runs check for server side resources when the operator evaluates upgrade actions based on changes to the objects stored in the API server.

Note that in terms of roles, this operator requires quite a significant amount of access. The list was composed by capturing the failures to access resources with given verbs in the logs when running the operator.

Since the orchestrator CR can be deployed in any namespace, it is not possible to limit the access required by the controller to certain namespaces via Role/RoleBinding.

@masayag please take a look.

jordigilh added 30 commits

March 7, 2024 09:42


          First commit

e9b325a

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fixes various reconciliation issues ocurring when reconciling with th…

47426ad

…e helm operator

Signed-off-by: Jordi Gil <jgil@redhat.com>


          align knative CR specs

c5d94f2

Signed-off-by: Jordi Gil <jgil@redhat.com>


          add backstage missing default specs

d86f809

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Rewrite secret creation in rhdh

f0cd7b8

Signed-off-by: Jordi Gil <jgil@redhat.com>


          fix knativeeventing CRD mismatch

cc03b39

Signed-off-by: Jordi Gil <jgil@redhat.com>


          fix knative serverless webhook misalignment

e0b31c0

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Updated sonataflow related CRDs to the latest versions from github.com

0fb9df0

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Add pre/post hooks to install the operator before the CR manifests

17040a2

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Remove crds directory

65acd70

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Add hooks to operator related manifests

a1fda54

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Use custom helm-operator with dryrun options for server side

f188303

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Update janus image to 0.2.0

bb8f3b0

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Restore helper function to retrieve the cluster domain

f550f55

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Use post install job to install the backstage CR without requiring th…

74159e1

…e backstage CRD to be provided by this operator

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Add post-install hook to deploy serverless CRs

2a95a04

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Use Role/Rolebinding in knative cleanup hook

9e6729e

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Remove duplicated service account in cr hook

a536f4c

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix role/rolebinding in knative-hook

f649912

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Wait for CRD to be available in template helper function and refactor…

40f86ea

… all instances of wait for jobs to use this new approach

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Add check for APIResource when checking if resource is managed

bd559b8

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Sync with latest helm chart

b1b3a1d

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Increase wait for CRD deployed to 300 seconds

26e3e49

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix SA reference in wait for CRD job

d6caecc

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix lint issues

e807512

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix indentation in sonataflow.yaml

721e35a

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix yaml separator and remove left trim from include

0057b48

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix indentation in clusterrole and clusterrolebinding in wait_for tem…

…plate

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Typo on the serviceaccountname field in wait_for

8fb81f0

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Use apiextensions.k8s.io to retrieve CRDs in wait_for template

ff54cc2

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh added 7 commits

March 19, 2024 18:22


           Change task api version to v1

9a95983

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Fix sonataflow.yaml include template for persistence

a34a2d2

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Update .gitignore to ignore .DS_Store

c26cecb

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Remove logic to delete the sonataflow CSV instances in the pre-delete…

f156da2

… hook

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Use orchestrator as reference name

0804a16

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Update charts to version 0.2.8

807f1bd

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Update watches.yaml field to dryRunOption

031c9eb

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh force-pushed the first_release branch from 6367277 to 031c9eb Compare

March 26, 2024 20:16


          Added bundle manifests

46a9a81

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh force-pushed the first_release branch 2 times, most recently from ddb3426 to f8b64ba Compare

March 27, 2024 21:43


          Remove create,patch,delete and update verbs for CRDs in role.yaml and…

264d98e

… recreate CSV

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh force-pushed the first_release branch from f8b64ba to 264d98e Compare

March 27, 2024 21:44

jordigilh added 6 commits

March 27, 2024 17:58


          Add icon and minikube minimum version to CSV

bbc9757

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Define metadata name and namespace in csv:\n*Use parodos-orchestrator…

…-operator.v0.0.1 for name\n* Use openshift-operators for namespace

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Remove artifact file bundle/manifests/orchestrator_catalogservice.yaml

ea3bcb7

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Define the operator's name as parodos-orchestrator-operator

e403bbf

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Change SA name and labels

3505d3a

Signed-off-by: Jordi Gil <jgil@redhat.com>


          Rename references in bundle to parodos-orchestrator-operator

322ede8

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh force-pushed the first_release branch from 2352ee4 to 322ede8 Compare

March 28, 2024 14:39

masayag reviewed

View reviewed changes

Contributor

masayag left a comment

When running the helm chart in a non-devmode, there is a need to create the namespace and it is also expected to create the DB.

in devmode, the chart is responsible to create the namespace CR.

AFAIKT, we don't maintain the condition of the CR - how that kind of errors (missing namespace) are propagated to the user?

other than that, this looks pretty good.

Dockerfile

		@@ -0,0 +1,7 @@
		# Build the manager binary
		FROM quay.io/jordigilh/helm-operator:dev

Contributor

masayag Mar 28, 2024

would you like to replace this with the orchestartor organization on quay?
we can also move this repository to parodos-dev github org and use its Quay secret for that.

Collaborator Author

jordigilh Mar 29, 2024

I expect this to be replaced by the helm-operator container image in the next release of the operator-sdk now that this PR has been merged.

Makefile

+              # To re-generate a bundle for another specific version without changing the standard setup, you can:
+              # - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2)
+              # - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
+              VERSION ?= 0.0.1

Contributor

masayag Mar 28, 2024

should this version or any version be aligned with the orchestrator helm chart version?

Collaborator Author

jordigilh Mar 29, 2024

Yes if we plan to release the operator when new a new chart is released, regardless of its correctness. But I'd be careful about that since we would be risking releasing a version that contains a chart that may not work with the operator before we have tested it.

A reason for not coupling them is that there might be improvements to the helm operator (update the base container image for instance) not tied to the helm chart that would require a release of the chart without changes just to align with the version in the operator.

config/manager/kustomization.yaml Outdated Show resolved Hide resolved

jordigilh force-pushed the first_release branch from a0e4565 to e266f29 Compare

March 29, 2024 01:01


          Rebuilt from scratch using the same helm chart version (0.2.8)

d7ee0f5

* Renamed operator to "Orchestrator Operator"
* Removed references in the name to Parodos
* Rebuilt using operator-sdk v1.33 because of an issue in the make bundle operation in v1.34.1 (operator-framework/operator-sdk#6698)
* Grouped roles for namespace into a single entry

Signed-off-by: Jordi Gil <jgil@redhat.com>

jordigilh force-pushed the first_release branch from e266f29 to d7ee0f5 Compare

March 29, 2024 01:02

Collaborator Author

jordigilh commented Mar 29, 2024

AFAIKT, we don't maintain the condition of the CR - how that kind of errors (missing namespace) are propagated to the user?

We could add the check for the namespace to be there and fail otherwise. WDYT?

Contributor

masayag commented Apr 1, 2024

Pls note operator-framework/operator-sdk#6691 was merged.

masayag reviewed

View reviewed changes

Makefile Outdated

-              # For example, running 'make bundle-build bundle-push catalog-build catalog-push' will build and push both
-              # parodos.dev/operator-bundle:$VERSION and parodos.dev/operator-catalog:$VERSION.
-              IMAGE_TAG_BASE ?= quay.io/parodos-dev/orchestrator-controller
+              IMAGE_TAG_BASE ?= quay.io/orchestrator/controller-manager

Contributor

masayag Apr 1, 2024

Should we use orchestrator-operator as image name instead? if this is the default name generated by the SDK, and has a wider effect on the rest of the generated code, we can use it.

Collaborator Author

jordigilh Apr 1, 2024 •

edited

Loading

It's defined here:
https://github.com/jordigilh/orchestrator-helm-operator/blob/d7ee0f512ce88cfe76e79b216a184d6af6a86357/PROJECT#L10-L12

We can set the value we want anyway. I'll change it to orchestrator-operator as suggested.

Makefile

@@ @@ -48,7 +46,7 @@ endif @@
               # Set the Operator SDK version to use. By default, what is installed on the system is used.
               # This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit.
-              OPERATOR_SDK_VERSION ?= v1.34.1
+              OPERATOR_SDK_VERSION ?= v1.33.0

Contributor

masayag Apr 1, 2024

Why a lower version?

Collaborator Author

jordigilh Apr 1, 2024

There seems to be an issue with 1.34.1 on running the bundle target (make bundle) that produces incomplete artifacts:
operator-framework/operator-sdk#6698
I reverted to use the previously available version (1.33.0) to avoid the issue mentioned.


          Rename container image to orchestrator-operator and apply the same co…

cce0229

…nvention to other references using controller-manager as name

Signed-off-by: Jordi Gil <jgil@redhat.com>

masayag approved these changes

View reviewed changes

jordigilh merged commit 50e9e07 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment