update code for upstream notifications plugin #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converted to draft until orchestrator starts using the upstream notification plugin |
masayag
reviewed
May 8, 2024
| payload: | ||
| title: '"AAP Job Workflow " + $WORKFLOW.instanceId + " Failed"' | ||
| description: '"AAP job workflow id: " + $WORKFLOW.instanceId + " for job template id: " + (.jobTemplateId|tostring) + " failed."' | ||
| scope: "AAP Job Workflow" |
There was a problem hiding this comment.
we had a field 'origin'. there's no real use for it at the moment. the only available field in the new plugin that seemed to fit was 'scope'.
| @@ -1,5 +1,6 @@ | |||
| # Notifications Settings | |||
| quarkus.rest-client.notifications_openapi_yaml.url=${BACKSTAGE_NOTIFICATIONS_URL:http://localhost:7007/api/notifications} | |||
There was a problem hiding this comment.
Does the URL remain the same?
There was a problem hiding this comment.
the base url remains the same
FLPATH-1249 https://issues.redhat.com/browse/FLPATH-1249 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com> Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLPATH-1249
https://issues.redhat.com/browse/FLPATH-1249