-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update code for upstream notifications plugin #45
base: main
Are you sure you want to change the base?
Conversation
converted to draft until orchestrator starts using the upstream notification plugin |
payload: | ||
title: '"AAP Job Workflow " + $WORKFLOW.instanceId + " Failed"' | ||
description: '"AAP job workflow id: " + $WORKFLOW.instanceId + " for job template id: " + (.jobTemplateId|tostring) + " failed."' | ||
scope: "AAP Job Workflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of scope
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had a field 'origin'. there's no real use for it at the moment. the only available field in the new plugin that seemed to fit was 'scope'.
@@ -1,5 +1,6 @@ | |||
# Notifications Settings | |||
quarkus.rest-client.notifications_openapi_yaml.url=${BACKSTAGE_NOTIFICATIONS_URL:http://localhost:7007/api/notifications} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the URL remain the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the base url remains the same
FLPATH-1249 https://issues.redhat.com/browse/FLPATH-1249 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com> Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
FLPATH-1249
https://issues.redhat.com/browse/FLPATH-1249