-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for mta v6.2.2 and v7.0.2 manifests #266
Conversation
it's a pity that we have a lot of duplicated code, but probably acceptable in this context. Maube Moti and Gabriel have a different opinion on this topic. |
@rhkp is this PR rebased on the workflows branch? Can we adjust the versions to match the one from the origin repository? |
Sure. Let me do that. Thanks. |
@masayag Thanks for the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this part, but I can't see the container image built for those workflows from the serverless-workflows repository specified in the sonataflow CRs.
duration: PT1H | ||
podTemplate: | ||
container: | ||
resources: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image should be specified here, in a similar way as done for the existing mta workflow:
https://github.com/parodos-dev/serverless-workflows-config/blob/main/charts/mta/templates/01-sonataflow_mtaanalysis.yaml#L252
so it appears the repository was never created and the image wasn't pushed: https://github.com/parodos-dev/serverless-workflows/actions/workflows/mta-v6.x.yml
I'm going to create the repositories in quay for both workflows (v6 and v7) and repeat the failed actions.
Only then this CR can be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now things looks better - there is an image created successfully at quay.io/orchestrator/serverless-workflow-mta-v6.x:1bde42520bd287ded1eab55380a2d17912f0f32a
and it needs to be added here.
then, by merging this PR, the next failed task in the job below should be resolved:
https://github.com/parodos-dev/serverless-workflows/actions/runs/9552838333/job/26330499375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the meantime, running the build for mta-v7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the 01-XX 02-XX and 03-XX files, they will be generated by the CI
mta.url = ${MTA_URL:http://tackle-ui.my-konveyor-operator.svc.cluster.local:8080} | ||
quarkus.rest-client.mta_json.url = ${mta.url} | ||
quarkus.rest-client.notifications.url=${BACKSTAGE_NOTIFICATIONS_URL:http://backstage-backstage.rhdh-operator/api/notifications/} | ||
quarkus.openapi-generator.mta_json.auth.bearerAuth.bearer-token=${MTA_HUB_TOKEN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this and how to generate one?
There is no such props in https://github.com/parodos-dev/serverless-workflows/blob/main/mta-v7.x/application.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were generated using make command with gen-manifests option.
https://github.com/parodos-dev/serverless-workflows/blob/main/Makefile#L173
Set unique name for the chart. mta is the name of the existing MTA workflow chart.
Set unique name for the mta v6 chart. mta is the name of the existing MTA workflow chart.
Signed-off-by: Moti Asayag <masayag@redhat.com> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Moti Asayag <masayag@redhat.com> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Moti Asayag <masayag@redhat.com> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
Hi @dmartinol / @masayag ,
Please review and merge or provide feedback.
This is part 2 (instructions 5-7) as provided at https://github.com/parodos-dev/serverless-workflows?tab=readme-ov-file#to-introduce-a-new-workflow
Thanks.