Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2K - send request with dump cli logs to true #298

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabriel-farache
Copy link
Collaborator

@gabriel-farache gabriel-farache commented Jul 5, 2024

Needs konveyor/move2kube-api#166 to be merged first

Related to konveyor/move2kube-api#159 but it appears the lack of info does not come from the API but from the CLI itslef, this PR may be discarded in the future

@masayag
Copy link
Collaborator

masayag commented Jul 21, 2024

@gabriel-farache The PR message refers to the following issue which is already merged.

Needs konveyor/move2kube-api#166 to be merged first

Is there a need to wait for a release of it or can this PR be rebased and completed?

@gabriel-farache
Copy link
Collaborator Author

gabriel-farache commented Jul 22, 2024

@masayag We have 2 choices: wait for a konveyor release of M2K that would contain our fix/feature or build our own image and use it (like we used to do)

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

@masayag We have 2 choices: wait for a konveyor release of M2K that would contain our fix/feature or build our own image and use it (like we used to do)

any idea when they intend to release or if we can request from them to release?

@gabriel-farache
Copy link
Collaborator Author

gabriel-farache commented Jul 22, 2024

any idea when they intend to release or if we can request from them to release?

@masayag No idea, I asked konveyor/move2kube-api#159

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

any idea when they intend to release or if we can request from them to release?

@masayag No idea, I asked konveyor/move2kube-api#159

perfect, a new release was triggered, please monitor and move out of draft one it is ready to be merged.

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

also, rebased is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants