Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: move to use the maintained orchestrator-k8s helm chart #309

Closed
wants to merge 1 commit into from

Conversation

rgolangh
Copy link
Collaborator

Signed-off-by: Roy Golan rgolan@redhat.com

@rgolangh rgolangh force-pushed the move-e2e-to-orchestrator-k8s branch 3 times, most recently from 8bfb6b0 to dcdf808 Compare July 10, 2024 14:47
@rgolangh
Copy link
Collaborator Author

@gfarache @masayag hoping this change will help catching errors like the auth issues with notifs more quicker

This will work nicely with the change by @masayag to always send notifications.

Also, I assume the orchestrator-k8s chart would need some changes, like bumping the notification plugin versions, and few config changes.

@rgolangh rgolangh force-pushed the move-e2e-to-orchestrator-k8s branch from dcdf808 to 72af14d Compare July 10, 2024 14:55
@masayag
Copy link
Collaborator

masayag commented Jul 10, 2024

@gfarache @masayag hoping this change will help catching errors like the auth issues with notifs more quicker

This will work nicely with the change by @masayag to always send notifications.

Also, I assume the orchestrator-k8s chart would need some changes, like bumping the notification plugin versions, and few config changes.

The required changes are replacing the existing notifications plugins with the new one and add also the signal plugin.
ATM we have those artifacts on in the staging registry - https://npm.stage.registry.redhat.com/

@rgolangh
Copy link
Collaborator Author

@gfarache @masayag hoping this change will help catching errors like the auth issues with notifs more quicker
This will work nicely with the change by @masayag to always send notifications.
Also, I assume the orchestrator-k8s chart would need some changes, like bumping the notification plugin versions, and few config changes.

The required changes are replacing the existing notifications plugins with the new one and add also the signal plugin. ATM we have those artifacts on in the staging registry - https://npm.stage.registry.redhat.com/

no upstream packages?

@masayag
Copy link
Collaborator

masayag commented Jul 10, 2024

@gfarache @masayag hoping this change will help catching errors like the auth issues with notifs more quicker
This will work nicely with the change by @masayag to always send notifications.
Also, I assume the orchestrator-k8s chart would need some changes, like bumping the notification plugin versions, and few config changes.

The required changes are replacing the existing notifications plugins with the new one and add also the signal plugin. ATM we have those artifacts on in the staging registry - https://npm.stage.registry.redhat.com/

no upstream packages?

I am unaware of a version of those plugins being released as dynamic plugins to the upstream.
Let's confirm this with @batzionb @mareklibra

@batzionb
Copy link

There are upstream plugins for the orchestrator plugin
Different story with notifications plugins

Signed-off-by: Roy Golan <rgolan@redhat.com>
@rgolangh rgolangh force-pushed the move-e2e-to-orchestrator-k8s branch from 72af14d to 53ec1dd Compare July 11, 2024 12:31
@rgolangh
Copy link
Collaborator Author

closing in favour of #313

@rgolangh rgolangh closed this Jul 22, 2024
@masayag masayag deleted the move-e2e-to-orchestrator-k8s branch July 31, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants