Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass original event to callback to preventDefault #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnybenson
Copy link

@johnnybenson johnnybenson commented Jul 27, 2020

When overriding shortcuts that may have existing functionality, you would need to preventDefault.

By passing the event to the callback, it lets the developer decide what to do!

Suggesting as an alternative to #92

When overriding shortcuts that may have existing functionality, you would need to preventDefault.

By passing the event to the callback, it lets the developer decide what to do!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant