feat: Implementing encrypted local storage for user sessions with tests #1211

rommansabbir · 2024-08-15T16:44:40Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

From an existing PR:


Currently the SDK saved cached user session as clear text files.
Feature / Enhancement Description

Encrypting cached user sessions using Jetpack security features to prevent session copy on rooted devices.
Alternatives / Workarounds

No workarounds at the moment.
3rd Party References

I found this [gist](https://github.com/appmattus/layercache/tree/main/testutils/src/main/kotlin/com/appmattus/layercache/keystore) which provides a good way for testing encryption methods on Robolectric.

Closes: #1192

Implemented encrypted local storage for user sessions with tests.
It was an existing PR.

Approach

Added EncryptedFileObjectStore to enable encryption and support CRUD operations.
Enabled migration in ParseCorePlugins when getCurrentUserController() is invoked by ParseObjectStoreMigrator.
Updated ParseFileUtils to support CRUD operations for encrypted objects.

Testing:

Added tests for the new functionality and updates.

TODOs before merging

Add tests - gradle clean test
Add changes to documentation (guides, repository pages, in-code descriptions)

…f the same ParseFile from multiple threads

This reverts commit 8d8a00d

parse-github-assistant · 2024-08-15T16:44:44Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

rommansabbir · 2024-10-05T15:39:35Z

@mtrezza

mtrezza · 2024-10-05T22:23:16Z

parse/src/main/java/com/parse/ParseObjectStoreMigrator.java

+        return store.getAsync()
+                .continueWithTask(
+                        new Continuation<T, Task<T>>() {
+                            @Override
+                            public Task<T> then(Task<T> task) throws Exception {
+                                if (task.getResult() != null) return task;
+                                return legacy.getAsync()
+                                        .continueWithTask(
+                                                new Continuation<T, Task<T>>() {
+                                                    @Override
+                                                    public Task<T> then(Task<T> task)
+                                                            throws Exception {
+                                                        T object = task.getResult();
+                                                        if (object == null) return task;
+                                                        return legacy.deleteAsync()
+                                                                .continueWith(
+                                                                        task1 ->
+                                                                                ParseTaskUtils.wait(
+                                                                                        store
+                                                                                                .setAsync(
+                                                                                                        object)))
+                                                                .onSuccess(task1 -> object);
+                                                    }
+                                                });
+                            }
+                        });


Is there a better way to structure this code?

Will look into it.

mtrezza · 2024-10-05T22:24:24Z

bolts-tasks/src/main/java/com/parse/boltsinternal/CancellationTokenSource.java

@@ -46,7 +46,9 @@ public boolean isCancellationRequested() {
        }
    }

-    /** @return the token that can be passed to asynchronous method to control cancellation. */


Please revert these unrelated changes in bolts, twitter and wherever you find these comment-only refactors.

mtrezza · 2024-10-05T22:29:14Z

As this PR is a continuation of #1191, did you consider the PR review comments and discussion feedback there when creating this PR?

rommansabbir · 2024-10-06T14:13:25Z

As this PR is a continuation of #1191, did you consider the PR review comments and discussion feedback there when creating this PR?

Yes, I did. Did i missed something during the discussion feedback? I will again look into the discussion. Thanks for the attention.

mtrezza · 2024-10-06T22:42:43Z

Did i missed something during the discussion feedback?

Noting specific, I didn't check the discussion there, only noticed that there has been extensive discussion.

techyourchance and others added 8 commits August 21, 2022 16:12

Bugfix: fixes parse-community#1155 - supporting concurrent download o…

19a252a

…f the same ParseFile from multiple threads

Update parse/src/test/java/com/parse/ParseFileControllerTest.java

d2135c2

Update parse/src/test/java/com/parse/ParseFileControllerTest.java

d5c50f4

ci failing : fixed spotless violations

8d8a00d

Revert "ci failing : fixed spotless violations"

c19946b

This reverts commit 8d8a00d

fix: ci failing on PR parse-community#1179

ec87160

Merge branch 'parse-community:master' into master

4653c28

feat: Implementing encrypted local storage for user sessions with tests

4d0494a

rommansabbir added 2 commits August 16, 2024 00:34

fix : spotless apply issue fixed, using a new version.

6d208d7

refactoring : removed duplicate code

6887cfe

rommansabbir requested a review from azlekov September 27, 2024 13:35

Merge branch 'master' into master

eb7142a

mtrezza reviewed Oct 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implementing encrypted local storage for user sessions with tests #1211

feat: Implementing encrypted local storage for user sessions with tests #1211

rommansabbir commented Aug 15, 2024 •

edited

Loading

parse-github-assistant bot commented Aug 15, 2024 •

edited

Loading

rommansabbir commented Oct 5, 2024

mtrezza Oct 5, 2024

rommansabbir Oct 6, 2024

mtrezza Oct 5, 2024 •

edited

Loading

rommansabbir Oct 6, 2024

mtrezza commented Oct 5, 2024

rommansabbir commented Oct 6, 2024

mtrezza commented Oct 6, 2024

feat: Implementing encrypted local storage for user sessions with tests #1211

Are you sure you want to change the base?

feat: Implementing encrypted local storage for user sessions with tests #1211

Conversation

rommansabbir commented Aug 15, 2024 • edited Loading

New Pull Request Checklist

Issue Description

Closes: #1192

Approach

TODOs before merging

parse-github-assistant bot commented Aug 15, 2024 • edited Loading

Thanks for opening this pull request!

rommansabbir commented Oct 5, 2024

mtrezza Oct 5, 2024

Choose a reason for hiding this comment

rommansabbir Oct 6, 2024

Choose a reason for hiding this comment

mtrezza Oct 5, 2024 • edited Loading

Choose a reason for hiding this comment

rommansabbir Oct 6, 2024

Choose a reason for hiding this comment

mtrezza commented Oct 5, 2024

rommansabbir commented Oct 6, 2024

mtrezza commented Oct 6, 2024

rommansabbir commented Aug 15, 2024 •

edited

Loading

parse-github-assistant bot commented Aug 15, 2024 •

edited

Loading

mtrezza Oct 5, 2024 •

edited

Loading