-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Http client exception not handled properly resulting in incorrectly formatted error #1021
base: master
Are you sure you want to change the base?
fix: Http client exception not handled properly resulting in incorrectly formatted error #1021
Conversation
Thanks for opening this pull request! |
@@ -22,6 +22,12 @@ ParseResponse buildParseResponseWithException(Exception exception) { | |||
)); | |||
} | |||
|
|||
if (exception is ClientException) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use two clients, dio
and http
, at Parse Flutter !
In this change you are using the functions of the http
package. Will this not cause any problems when we use the dio package client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DioException
is already being handled above but ClientException
was missing.
Can you please run CI? |
@mbfakourii done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
+ Coverage 43.37% 43.47% +0.10%
==========================================
Files 61 61
Lines 3463 3466 +3
==========================================
+ Hits 1502 1507 +5
+ Misses 1961 1959 -2 ☔ View full report in Codecov by Sentry. |
I will reformat the title to use the proper commit message syntax. |
I rephrased the PR title; not sure whether it accurately describes the issue, could you please review? |
I think it's better. |
There is still an open review discussion and the changelog entry + version bump is missing in the PR. See other PRs on how they are done. Then we can go ahead and merge. |
Pull Request
Issue
Closes: #1022
Approach
Tasks