Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add access client in parse clients #1025

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Nov 28, 2024

Pull Request

Issue

Closes: #1023

Approach

Add a function to access client in parse clients.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add access client in parse clients fix: Add access client in parse clients Nov 28, 2024
Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii changed the title fix: Add access client in parse clients fix: add access client in parse clients Nov 28, 2024
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add access client in parse clients fix: Add access client in parse clients Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.72%. Comparing base (c388545) to head (e783ecd).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   43.37%   43.72%   +0.35%     
==========================================
  Files          61       61              
  Lines        3463     3465       +2     
==========================================
+ Hits         1502     1515      +13     
+ Misses       1961     1950      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested a review from a team November 28, 2024 14:23
Copy link

@chadpav chadpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward.

@mtrezza
Copy link
Member

mtrezza commented Nov 30, 2024

Could you rephrase the PR title to better understand the new feature? Maybe also add the class or method name.

@@ -1,3 +1,9 @@
## [8.0.1](https://github.com/parse-community/Parse-SDK-Flutter/compare/flutter-8.0.0...flutter-8.0.1) (2024-11-28)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a feature PR, then the version should be 8.1.0

Copy link
Member Author

@mbfakourii mbfakourii Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

@@ -14,6 +14,8 @@ class ParseDioClient extends ParseClient {

late _ParseDioClient _client;

dio.Dio get dioClient => _client;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cov missing, add tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

@mbfakourii mbfakourii requested a review from a team December 17, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access dio or http client in ParseDioClient or ParseHTTPClient
3 participants