fix: Parse.Query.subscribe() does not return a rejected promise on error in Cloud Code Triggers beforeConnect or beforeSubscribe
#1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
|
Since this is a breaking change, how would you like to proceed - add a temporary Parse Server option (or maybe there is an alternative?) or wait to merge until Parse Server 6? |
|
Which approach do you think is best? It’s not a major issue so perhaps we can wait |
|
Can you think of a way to support both for a while without making it a breaking change or adding a Parse Server option? Otherwise up to you, whatever you think is best. Should we add this as a feature or fix? The issue is currently classified as feature. |
mtrezza
changed the title
Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe
|
That would be good |
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribeParse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe
mtrezza
added
the
state:breaking
Codecov ReportBase: 99.93% // Head: 99.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha #1490 +/- ##
==========================================
- Coverage 99.93% 99.89% -0.04%
==========================================
Files 61 61
Lines 5966 5973 +7
Branches 1366 1367 +1
==========================================
+ Hits 5962 5967 +5
- Misses 4 6 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mtrezza
reviewed
Nov 14, 2022
There was a problem hiding this comment.
How can be best explain the "breaking" aspect of this change?
Calling
Parse.Query.subscribe()will now return a rejected promise if an error is thrown in Cloud Code TriggersbeforeConnectorbeforeSubscribe; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create anerror.onlistener to handle these errors.
Does that make sense?
|
Yes, that sounds good to me |
mtrezza
changed the title
Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribebeforeConnect or beforeSubscribe does not reject promise of Parse.Query.subscribe()
mtrezza
changed the title
beforeConnect or beforeSubscribe does not reject promise of Parse.Query.subscribe()Parse.Query.subscribe() does not return a rejected promise on error in Cloud Code Triggers beforeConnect or beforeSubscribe
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 15, 2022
# [4.0.0-alpha.2](4.0.0-alpha.1...4.0.0-alpha.2) (2022-11-15) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
|
🎉 This change has been released in version 4.0.0-alpha.2 |
|
The label |
parse-github-assistant
bot
removed
the
state:released-alpha
mtrezza
pushed a commit
to mtrezza/Parse-SDK-JS
that referenced
this pull request
Jan 22, 2023
…error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` (parse-community#1490) BREAKING CHANGE: Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (parse-community#1490)
mtrezza
pushed a commit
to mtrezza/Parse-SDK-JS
that referenced
this pull request
Jan 22, 2023
# [4.0.0-alpha.2](parse-community/Parse-SDK-JS@4.0.0-alpha.1...4.0.0-alpha.2) (2022-11-15) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([parse-community#1490](parse-community#1490)) ([96d7174](parse-community@96d7174)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (parse-community#1490) ([96d7174](96d7174))
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 23, 2023
# [4.0.0-beta.1](3.5.1...4.0.0-beta.1) (2023-01-23) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) * Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b)) ### Features * Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31)) * Add node 19 support ([8ed0fab](8ed0fab)) * Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196)) ### Performance Improvements * Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174)) * This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
|
🎉 This change has been released in version 4.0.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 23, 2023
# [4.0.0](3.5.1...4.0.0) (2023-01-23) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) * Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b)) ### Features * Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31)) * Add node 19 support ([8ed0fab](8ed0fab)) * Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196)) ### Performance Improvements * Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174)) * This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
|
🎉 This change has been released in version 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Cloud errors thrown from
beforeConnectandbeforeSubscribewill now catch, just like errors fromquery.findRelated issue: #1489
Closes #1489
Approach
Throws error to subscription promise if error occurs
TODOs before merging