fix: Parse.Object.get returns array instead of object if key name is number-like
#2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
This was referenced Jul 2, 2024
mtrezza
commented
Jul 5, 2024
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
commented
Jul 5, 2024
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
commented
Jul 5, 2024
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
|
@mtrezza this fix would return wrong output e.g.
|
|
An index of 0 is not required for an array to be an array. See #2198 (comment). |
dplewis
suggested changes
Jul 5, 2024
dplewis
suggested changes
Jul 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2201 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6358 +172
Branches 1499 1528 +29
==========================================
+ Hits 6186 6358 +172 ☔ View full report in Codecov by Sentry. |
|
@dplewis anything else that should be removed from the changes in https://github.com/parse-community/Parse-SDK-JS/pull/2120/files? Or can we merge |
|
Thats it, this is ready to merge |
mtrezza
changed the title
Parse.Object.get returns array instead of object value if key name is number-like
mtrezza
changed the title
Parse.Object.get returns array instead of object value if key name is number-likeParse.Object.get returns array instead of object if key name is number-like
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 7, 2024
# [5.3.0-alpha.2](5.3.0-alpha.1...5.3.0-alpha.2) (2024-07-07) ### Bug Fixes * `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2))
|
🎉 This change has been released in version 5.3.0-alpha.2 |
|
🎉 This change has been released in version 5.3.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 7, 2024
|
🎉 This change has been released in version 5.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #2198
Approach
Issue demo
Tasks