Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test to return correct field values #9179

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 7, 2024

This test is to ensure that server-side changes like #9115 don't cause issues like parse-community/Parse-SDK-JS#2198. Same test added to JS SDK in parse-community/Parse-SDK-JS#2201.

Copy link

parse-github-assistant bot commented Jul 7, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis
Copy link
Member

dplewis commented Jul 7, 2024

This will need the next SDK release to work.

@mtrezza
Copy link
Member Author

mtrezza commented Jul 7, 2024

Yes, I'll release a stable version of the JS SDK later today and then merge that in Parse Server -- done as v5.3.0

spec/ParseObject.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (dca187f) to head (228b4fa).
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9179   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files         186      186           
  Lines       14729    14729           
=======================================
+ Hits        13866    13867    +1     
+ Misses        863      862    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 2ecc5a5 into parse-community:alpha Jul 7, 2024
21 of 26 checks passed
@mtrezza mtrezza deleted the test-add-field-value-test branch July 7, 2024 17:10
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.15

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 9, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants