Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context in destroy, saveAll, get, find hooks. #1159

Merged

Conversation

yog27ray
Copy link
Contributor

@yog27ray yog27ray commented May 3, 2020

This is extension of the #1150. To pass context in following calls.

  1. Parse.Object.destroy
  2. Parse.Object.saveAll
  3. Parse.Query.get
  4. Parse.Query.find
  5. Parse.Query.first
  6. Parse.Query.each
  7. Parse.Cloud.run
  8. Parse.Object.destroyAll

….saveAll, Parse.Query.get, Parse.Query.find, Parse.Query.first, Parse.Query.each
@yog27ray yog27ray changed the title add context to Parse.Object.fetch, Parse.Object.destroy, Parse.Object… Pass context in destroy, saveAll, get, find hooks. May 3, 2020
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #1159 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   92.22%   92.38%   +0.15%     
==========================================
  Files          54       54              
  Lines        5272     5290      +18     
  Branches     1180     1189       +9     
==========================================
+ Hits         4862     4887      +25     
+ Misses        410      403       -7     
Impacted Files Coverage Δ
src/Cloud.js 93.33% <100.00%> (+0.31%) ⬆️
src/ParseObject.js 90.46% <100.00%> (+0.84%) ⬆️
src/ParseQuery.js 96.27% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b861da...8aea505. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis
Copy link
Member

dplewis commented Jul 1, 2020

@yog27ray We can do a Release today to include your changes. Then we can start on the Server Side

@dplewis dplewis merged commit 3f30a38 into parse-community:master Jul 1, 2020
@yog27ray
Copy link
Contributor Author

yog27ray commented Jul 4, 2020

thanks, @dplewis for merging the PR. I will update the server PR also.

@yog27ray yog27ray deleted the add-context-to-pending-hooks branch January 24, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants