Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PushStatus on Parse.Push #1302

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Support PushStatus on Parse.Push #1302

merged 1 commit into from
Feb 22, 2021

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 22, 2021

Similar to how jobStatus is handled.

  • Parse.Push.send now returns the pushStatusId
  • Add useMasterKey to Parse.Push.send
  • Add new Parse.Push.getPushStatus
  • Add new Push Integration tests.
const pushStatusId = await Parse.Push.send(payload);
const pushStatus = await Parse.Push.getPushStatus(pushStatusId);

This is currently a breaking change. Parse.Push.send returned { result: true } before.

@dplewis dplewis changed the title Support pushStatus on Parse.Push Support PushStatus on Parse.Push Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #1302 (8359b10) into master (10002de) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         5823      5834   +11     
  Branches      1306      1311    +5     
=========================================
+ Hits          5823      5834   +11     
Impacted Files Coverage Δ
src/Push.js 100.00% <100.00%> (ø)
src/RESTController.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a4da2...4515870. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@dplewis dplewis merged commit 3fb14ed into master Feb 22, 2021
@dplewis dplewis deleted the push-status branch February 22, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants