-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nested increment on undefined fields #1303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 5837 5832 -5
Branches 1312 1310 -2
=========================================
- Hits 5837 5832 -5
Continue to review full report at Codecov.
|
What is the change? Is a new field with this PR incremented when saving? |
The change is that we are allowing this request to go to the server. The server doesn't support this request yet. I'll try to do a PR on the server side. I would like this merged to test it on the server side. |
Do we have enough integration test in this repo to ensure letting this go to the server has no detrimental effects? |
Technically the other SDK's don't prevent you from doing this. This also mean that a user can use the REST API and get the same results. Dot notation didn't exist in this SDK until I added it. #729 Since there is that unhandled promise rejection. We can't really test much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Calling increment on a field that doesn't exists (serverData stored in object state) gets ignored.
I believe this was ignored because the server doesn't support it and throws the following error