Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EventuallyQueue): Poll against /health endpoint #1305

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 23, 2021

The /health endpoint has been supported on the server since 2.2.5.
This fixes an issue where a 403 would let us know that server was online.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1305 (641ec2e) into master (1abb841) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1305   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         5837      5839    +2     
  Branches      1312      1312           
=========================================
+ Hits          5837      5839    +2     
Impacted Files Coverage Δ
src/EventuallyQueue.js 100.00% <100.00%> (ø)
src/ParseQuery.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abb841...641ec2e. Read the comment docs.

src/EventuallyQueue.js Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit 24a6d60 into master Feb 23, 2021
@dplewis dplewis deleted the polling-health branch February 23, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants