fix: creating a Parse.File with base64 string fails for some file types #1467

RazvanCristian · 2022-03-29T17:05:31Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Related issue: #1466

Approach

Reworked logic for base64 formatting in ParseFile.js.

TODOs before merging

Add tests
Add entry to changelog

parse-github-assistant · 2022-03-29T17:05:33Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

changelogs/CHANGELOG_release.md

src/__tests__/ParseFile-test.js

src/ParseFile.js

src/__tests__/ParseFile-test.js

src/ParseFile.js

mtrezza

Tests failing, please request another review from @parse-community/js-sdk-review when this is ready.

RazvanCristian · 2022-04-04T07:17:38Z

Tests failing, please request another review from @parse-community/js-sdk-review when this is ready.

Tests are failing because you're using node 14.19.1, while the current LTS version is node 16.14.2.

||= operator was added in 15.0.0. Logical OR assignment (||=)

mtrezza · 2022-04-04T09:26:18Z

Can you adapt the code to pass? We won't change the node engine version at this point. Node 12 and 14 are still under LTS.

RazvanCristian · 2022-04-04T17:31:58Z

Done.

mtrezza

Tests still fail, could you take a look? And please let me know if the new PR title is correct.

RazvanCristian · 2022-04-18T21:12:59Z

Tests still fail, could you take a look? And please let me know if the new PR title is correct.

Sorry for taking so long, I had some work to do.
I updated the PR and checked that it passes the tests with version v14.19.1. It passes all the tests and there should be no other problems.

mtrezza · 2022-04-18T23:32:31Z

I changed the PR title because the previous one was difficult to read. It seems you changed it back. What's incorrect or missing for the title:

fix: creating a Parse.File with base64 string fails for some file types

codecov · 2022-04-20T23:57:39Z

Codecov Report

Merging #1467 (551b0a2) into alpha (62dc989) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            alpha    #1467   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5948     5949    +1     
  Branches     1354     1357    +3     
=======================================
+ Hits         5945     5946    +1     
  Misses          3        3

Impacted Files	Coverage Δ
src/ParseFile.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90ae25...551b0a2. Read the comment docs.

src/ParseFile.js

mtrezza

Looks good to me! Thanks for this fix, let's just wait for the CI to pass.

mtrezza · 2022-04-28T19:47:45Z

@rubenatorio Do you want to do a final review before we merge?

## [3.4.3-alpha.1](3.4.2...3.4.3-alpha.1) (2022-05-02) ### Bug Fixes * creating a Parse.File with base64 string fails for some file types ([#1467](#1467)) ([c07d6c9](c07d6c9))

parseplatformorg · 2022-05-02T20:17:33Z

🎉 This change has been released in version 3.4.3-alpha.1

## [3.4.3-beta.1](3.4.2...3.4.3-beta.1) (2022-06-18) ### Bug Fixes * creating a Parse.File with base64 string fails for some file types ([#1467](#1467)) ([c07d6c9](c07d6c9)) * invalid name for `Parse.Role` throws incorrect error ([#1481](#1481)) ([8326a6f](8326a6f))

parseplatformorg · 2022-06-18T13:05:17Z

🎉 This change has been released in version 3.4.3-beta.1

## [3.4.3](3.4.2...3.4.3) (2022-07-02) ### Bug Fixes * creating a Parse.File with base64 string fails for some file types ([#1467](#1467)) ([c07d6c9](c07d6c9)) * invalid name for `Parse.Role` throws incorrect error ([#1481](#1481)) ([8326a6f](8326a6f))

parseplatformorg · 2022-07-02T12:26:06Z

🎉 This change has been released in version 3.4.3

Saquib764 · 2022-07-08T10:11:03Z

It seems there is still issue with Parse.File while creating base64 file.

I am generating data URL from canvas-

let url = canvas.toDataURL("image/png");

const file = new Parse.File(`shading_texture.png`, { base64: url.split('base64,')[1] });
await file.save()

Upon running this script, the frontend freezes for a couple of minutes and then fails.

The exact same script was working with version 3.4.2

I also tried the following script to extract base64 string. No success.

let base64 = url.replace('data:', '').replace(/^.+,/, '')

mtrezza · 2022-07-08T22:12:21Z

Could you open a new issue?

samateja · 2022-07-25T10:17:15Z

this fix is not working when i upload a video and convert the video to base64. The file size is around 17mb, do you suggest any other solution?

FransGH · 2022-08-18T11:45:04Z

See #1532

## [3.4.3](parse-community/Parse-SDK-JS@3.4.2...3.4.3) (2022-07-02) ### Bug Fixes * creating a Parse.File with base64 string fails for some file types ([parse-community#1467](parse-community#1467)) ([c07d6c9](parse-community@c07d6c9)) * invalid name for `Parse.Role` throws incorrect error ([parse-community#1481](parse-community#1481)) ([8326a6f](parse-community@8326a6f))

Fix base64 formatting

4e70741

RazvanCristian mentioned this pull request Mar 29, 2022

Wrong processing of a base64 string in accordance to RFC 2397 when calling new Parse.File #1466

Closed

4 tasks

RazvanCristian added 2 commits March 29, 2022 20:11

Add new test for base64 formatting

a05f681

Update changelog parse-community#1467

2c94df3

RazvanCristian changed the title ~~Fix base64 formatting~~ fix: base64 formatting Mar 29, 2022

mtrezza requested changes Mar 30, 2022

View reviewed changes

changelogs/CHANGELOG_release.md Outdated Show resolved Hide resolved

src/__tests__/ParseFile-test.js Outdated Show resolved Hide resolved

Revert changelog changes

9d462f3

RazvanCristian changed the title ~~fix: base64 formatting~~ fix: extract data from base64 with a filename parameter Mar 31, 2022

RazvanCristian added 2 commits March 31, 2022 16:12

Deleted unnecessary throw when the filetype is not specified

17f7074

Added test for base64 file with filename parameter

50728e4

RazvanCristian requested a review from mtrezza March 31, 2022 15:30

mtrezza reviewed Mar 31, 2022

View reviewed changes

src/ParseFile.js Outdated Show resolved Hide resolved

src/__tests__/ParseFile-test.js Show resolved Hide resolved

Add validation regex

e13000e

RazvanCristian requested a review from mtrezza March 31, 2022 17:47

Remove whitespace in regex

5225436

rubenatorio reviewed Apr 1, 2022

View reviewed changes

src/ParseFile.js Outdated Show resolved Hide resolved

RazvanCristian added 2 commits April 1, 2022 20:58

Default type text/plain

bbf960a

Rework; Update tests

75dea60

mtrezza linked an issue Apr 4, 2022 that may be closed by this pull request

Wrong processing of a base64 string in accordance to RFC 2397 when calling new Parse.File #1466

Closed

4 tasks

mtrezza requested changes Apr 4, 2022

View reviewed changes

Replace ||= operator

7b47bdd

RazvanCristian requested a review from mtrezza April 4, 2022 17:32

RazvanCristian and others added 2 commits April 6, 2022 15:42

Merge branch 'alpha' into alpha

f0b545b

Merge branch 'alpha' into alpha

ab8b6e7

mtrezza changed the title ~~fix: extract data from base64 with a filename parameter~~ fix: creating a Parse.File with base64 string fails for some file types Apr 9, 2022

mtrezza requested changes Apr 9, 2022

View reviewed changes

RazvanCristian changed the title ~~fix: wrong processing of a base64 string in accordance to RFC 2397 when calling new Parse.File~~ fix: creating a Parse.File with base64 string fails for some file types Apr 20, 2022

Test changes

02b9a79

mtrezza requested changes Apr 21, 2022

View reviewed changes

src/ParseFile.js Outdated Show resolved Hide resolved

Add new test case; rephrase error message

a368cbc

RazvanCristian requested a review from mtrezza April 28, 2022 19:34

Merge branch 'alpha' into alpha

cccdb9f

mtrezza approved these changes Apr 28, 2022

View reviewed changes

mtrezza added 2 commits April 30, 2022 02:31

Merge branch 'alpha' into alpha

7cc5f84

Merge branch 'alpha' into alpha

551b0a2

mtrezza merged commit c07d6c9 into parse-community:alpha May 2, 2022

parseplatformorg added the state:released-alpha Released as alpha version label May 2, 2022

parseplatformorg added the state:released-beta Released as beta version label Jun 18, 2022

parseplatformorg added the state:released Released as stable version label Jul 2, 2022

FransGH mentioned this pull request Aug 19, 2022

Remove inefficient/failing base64 check and add Buffer support to Parse.File() #1532

Closed

4 tasks

dplewis mentioned this pull request Nov 2, 2022

fix: File upload fails when uploading base64 data #1578

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: creating a Parse.File with base64 string fails for some file types #1467

fix: creating a Parse.File with base64 string fails for some file types #1467

RazvanCristian commented Mar 29, 2022 •

edited

Loading

parse-github-assistant bot commented Mar 29, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

RazvanCristian commented Apr 4, 2022

mtrezza commented Apr 4, 2022 •

edited

Loading

RazvanCristian commented Apr 4, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

RazvanCristian commented Apr 18, 2022

mtrezza commented Apr 18, 2022 •

edited

Loading

codecov bot commented Apr 20, 2022 •

edited

Loading

mtrezza left a comment

mtrezza commented Apr 28, 2022 •

edited

Loading

parseplatformorg commented May 2, 2022

parseplatformorg commented Jun 18, 2022

parseplatformorg commented Jul 2, 2022

Saquib764 commented Jul 8, 2022

mtrezza commented Jul 8, 2022

samateja commented Jul 25, 2022

FransGH commented Aug 18, 2022

fix: creating a Parse.File with base64 string fails for some file types #1467

fix: creating a Parse.File with base64 string fails for some file types #1467

Conversation

RazvanCristian commented Mar 29, 2022 • edited Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Mar 29, 2022 • edited Loading

Thanks for opening this pull request!

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

RazvanCristian commented Apr 4, 2022

mtrezza commented Apr 4, 2022 • edited Loading

RazvanCristian commented Apr 4, 2022 • edited Loading

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

RazvanCristian commented Apr 18, 2022

mtrezza commented Apr 18, 2022 • edited Loading

codecov bot commented Apr 20, 2022 • edited Loading

Codecov Report

mtrezza left a comment

Choose a reason for hiding this comment

mtrezza commented Apr 28, 2022 • edited Loading

parseplatformorg commented May 2, 2022

parseplatformorg commented Jun 18, 2022

parseplatformorg commented Jul 2, 2022

Saquib764 commented Jul 8, 2022

mtrezza commented Jul 8, 2022

samateja commented Jul 25, 2022

FransGH commented Aug 18, 2022

RazvanCristian commented Mar 29, 2022 •

edited

Loading

parse-github-assistant bot commented Mar 29, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Apr 4, 2022 •

edited

Loading

RazvanCristian commented Apr 4, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Apr 18, 2022 •

edited

Loading

codecov bot commented Apr 20, 2022 •

edited

Loading

mtrezza commented Apr 28, 2022 •

edited

Loading