Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Login with username, password and additional authentication data via ParseUser.logInWithAdditionalAuth #1955

Merged
merged 4 commits into from
Jul 23, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 23, 2023

Pull Request

Issue

It's not currently possible to login with additional auth data

Closes: #1807

Approach

Creates method logInWithAdditionalAuth

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@dblythy dblythy requested a review from a team July 3, 2023 04:53
@mtrezza mtrezza changed the title feat: ParseUser.logInWithAdditionalAuth feat: Login with username, password and additional authentication data via ParseUser.logInWithAdditionalAuth Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c03f72d) 99.88% compared to head (8698304) 99.88%.

❗ Current head 8698304 differs from pull request most recent head e0d3851. Consider uploading reports for the commit e0d3851 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1955   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          61       61           
  Lines        6133     6143   +10     
  Branches     1488     1491    +3     
=======================================
+ Hits         6126     6136   +10     
  Misses          7        7           
Impacted Files Coverage Δ
src/ParseUser.js 99.60% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza merged commit 2bad411 into parse-community:alpha Jul 23, 2023
parseplatformorg pushed a commit that referenced this pull request Jul 23, 2023
# [4.2.0-alpha.4](4.2.0-alpha.3...4.2.0-alpha.4) (2023-07-23)

### Features

* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 23, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 16, 2023
# [4.3.0-beta.1](4.2.0...4.3.0-beta.1) (2023-09-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 26, 2023
# [4.3.0-alpha.1](4.2.0...4.3.0-alpha.1) (2023-09-26)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-alpha.1

@dblythy dblythy deleted the login-with-auth branch October 3, 2023 23:09
parseplatformorg pushed a commit that referenced this pull request Nov 16, 2023
# [4.3.0](4.2.0...4.3.0) (2023-11-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support logIn with additional auth data
3 participants