Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Improve test coverage #2002

Merged
merged 3 commits into from
Aug 28, 2023
Merged

ci: Improve test coverage #2002

merged 3 commits into from
Aug 28, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 25, 2023

Pull Request

Issue

Add missing coverage

Approach

  • Test unsupported live queries
  • Test destroy with session token
  • Test live query connections / disconnection
  • Test internal nested object states
  • Add tests

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (343d0d7) 99.88% compared to head (a688c00) 100.00%.
Report is 1 commits behind head on alpha.

❗ Current head a688c00 differs from pull request most recent head cb6f6df. Consider uploading reports for the commit cb6f6df to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            alpha     #2002      +/-   ##
===========================================
+ Coverage   99.88%   100.00%   +0.11%     
===========================================
  Files          61        61              
  Lines        6121      6122       +1     
  Branches     1493      1493              
===========================================
+ Hits         6114      6122       +8     
+ Misses          7         0       -7
Files Changed Coverage Δ
src/ObjectStateMutations.js 100.00% <100.00%> (ø)
src/OfflineQuery.js 100.00% <100.00%> (+0.30%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from mtrezza August 26, 2023 02:17
@mtrezza mtrezza merged commit 94e7248 into parse-community:alpha Aug 28, 2023
8 checks passed
@dplewis dplewis deleted the ci-coverage branch August 28, 2023 21:59
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Aug 29, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @parseplatformorg @mtrezza