Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Docs fail with Cannot find module 'taffydb' #2036

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: Docs fail with Cannot find module 'taffydb' #2036

merged 1 commit into from
Oct 3, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 3, 2023

Pull Request

Issue

FATAL: Unable to load template: Cannot find module 'taffydb'
Require stack:
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/@parse/minami/publish.js
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/jsdoc/cli.js
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/jsdoc/jsdoc.js

Ref: #2034

Approach

  • Update @parse/minami
  • Update CI to check docs generates

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (64e6653) 100.00% compared to head (62076b2) 100.00%.
Report is 3 commits behind head on alpha.

❗ Current head 62076b2 differs from pull request most recent head 87c6473. Consider uploading reports for the commit 87c6473 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             alpha     #2036   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         6168      6176    +8     
  Branches      1498      1496    -2     
=========================================
+ Hits          6168      6176    +8
Files Coverage Δ
src/Cloud.js 100.00% <100.00%> (ø)
src/ParseObject.js 100.00% <100.00%> (ø)
src/Push.js 100.00% <100.00%> (ø)
src/RESTController.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from mtrezza October 3, 2023 19:42
mtrezza
mtrezza approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit dc91d0f into parse-community:alpha Oct 3, 2023
7 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 3, 2023
@semantic-release-bot
chore(release): 4.3.0-alpha.2 [skip ci]
e36ddaf 
# [4.3.0-alpha.2](4.3.0-alpha.1...4.3.0-alpha.2) (2023-10-03)

### Bug Fixes

* Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 3, 2023
@dplewis dplewis deleted the docs-check branch October 4, 2023 15:31
parseplatformorg pushed a commit that referenced this pull request Nov 16, 2023
@semantic-release-bot
chore(release): 4.3.1-beta.1 [skip ci]
42adbe9 
## [4.3.1-beta.1](4.3.0...4.3.1-beta.1) (2023-11-16)

### Bug Fixes

* Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc))
* Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f))
* Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f))
* Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d))
* Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.1-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 16, 2023
parseplatformorg pushed a commit that referenced this pull request Nov 18, 2023
@semantic-release-bot
chore(release): 4.3.1 [skip ci]
2f94e49 
## [4.3.1](4.3.0...4.3.1) (2023-11-18)

### Bug Fixes

* Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc))
* Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f))
* Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f))
* Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d))
* Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 18, 2023
parseplatformorg pushed a commit that referenced this pull request Nov 18, 2023
@semantic-release-bot
chore(release): 4.3.1-alpha.1 [skip ci]
1ddccb2 
## [4.3.1-alpha.1](4.3.0...4.3.1-alpha.1) (2023-11-18)

### Bug Fixes

* Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc))
* Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f))
* Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f))
* Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d))
* Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.1-alpha.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @parseplatformorg @mtrezza