Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Parse Schema #489

Merged
merged 7 commits into from
Nov 30, 2017
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 10, 2017

Pending: parse-community/parse-server#4240

Adds CRUD support for new Parse.Schema class.

@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #489 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   84.03%   84.57%   +0.53%     
==========================================
  Files          47       48       +1     
  Lines        3795     3947     +152     
  Branches      868      895      +27     
==========================================
+ Hits         3189     3338     +149     
- Misses        606      609       +3
Impacted Files Coverage Δ
src/Parse.js 82.08% <ø> (+0.27%) ⬆️
src/CoreManager.js 100% <100%> (ø) ⬆️
src/ParseSchema.js 100% <100%> (ø)
src/StorageController.react-native.js 83.33% <0%> (-2.39%) ⬇️
src/ParseQuery.js 94.01% <0%> (-0.03%) ⬇️
src/Push.js 100% <0%> (ø) ⬆️
src/Analytics.js 100% <0%> (ø) ⬆️
src/FacebookUtils.js 5.55% <0%> (ø) ⬆️
src/Cloud.js 96% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293e2e1...b6f6970. Read the comment docs.

_indexes: { [key: string]: mixed };

constructor(className: ?string) {
if (typeof className === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get jsdocs in all methods please? :)

@flovilmart
Copy link
Contributor

@dplewis, have a look at the overhaul I had to do for the docs to be compatible with JSDoc 3.0. That will help so I don’t have to re-do it :p

@dplewis
Copy link
Member Author

dplewis commented Nov 28, 2017

@flovilmart I'll add the documentation. Can you check to ensure the tests pass against parse-server 2.7.0 (travis)?

@flovilmart
Copy link
Contributor

Yes all good, I'll bump travis in my PR too :)

@dplewis
Copy link
Member Author

dplewis commented Nov 28, 2017

@flovilmart I always wondered are these tests still used?
tests

@flovilmart
Copy link
Contributor

Yes they are, those are the jest tests :(

@flovilmart
Copy link
Contributor

But they don’t report coverage, each file is unit tested by Jest, integration tests are run later and don’t produce coverage reports.

@dplewis
Copy link
Member Author

dplewis commented Nov 28, 2017

@flovilmart Can you look this over?

@flovilmart
Copy link
Contributor

Looking great man!

@flovilmart flovilmart merged commit b27ff60 into parse-community:master Nov 30, 2017
@dplewis dplewis deleted the schema-index branch November 30, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants