-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Parse Schema #489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 84.03% 84.57% +0.53%
==========================================
Files 47 48 +1
Lines 3795 3947 +152
Branches 868 895 +27
==========================================
+ Hits 3189 3338 +149
- Misses 606 609 +3
Continue to review full report at Codecov.
|
src/ParseSchema.js
Outdated
_indexes: { [key: string]: mixed }; | ||
|
||
constructor(className: ?string) { | ||
if (typeof className === 'string') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get jsdocs in all methods please? :)
@dplewis, have a look at the overhaul I had to do for the docs to be compatible with JSDoc 3.0. That will help so I don’t have to re-do it :p |
@flovilmart I'll add the documentation. |
Yes all good, I'll bump travis in my PR too :) |
@flovilmart I always wondered are these tests still used? |
Yes they are, those are the jest tests :( |
But they don’t report coverage, each file is unit tested by Jest, integration tests are run later and don’t produce coverage reports. |
@flovilmart Can you look this over? |
Looking great man! |
Pending: parse-community/parse-server#4240
Adds CRUD support for new Parse.Schema class.