Adds withCount query constraint #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 92.12% 92.14% +0.02%
==========================================
Files 54 54
Lines 4988 5006 +18
Branches 1114 1121 +7
==========================================
+ Hits 4595 4613 +18
Misses 393 393
Continue to review full report at Codecov.
|
davimacedo
requested changes
Jul 18, 2019
There was a problem hiding this comment.
@BufferUnderflower thanks for the PR. It seems really good for me. I just have a single question that I added below and I think we are ready to merge. @dplewis @acinader do you guys want to take a look as well?
dplewis
suggested changes
Jul 18, 2019
dplewis
suggested changes
Jul 19, 2019
davimacedo
approved these changes
Jul 19, 2019
dplewis
approved these changes
Jul 19, 2019
|
Good job @BufferUnderflower ! Would you be willed to add some information about it in JS docs? |
BufferUnderflower
added a commit
to BufferUnderflower/docs
that referenced
this pull request
Jul 21, 2019
This was referenced Jul 21, 2019
dplewis
pushed a commit
to parse-community/docs
that referenced
this pull request
Jul 23, 2019
* Documentation for ParseQuery.withCount See: parse-community/Parse-SDK-JS#865 parse-community/Parse-SDK-JS#868 * added disclaimer * remove extra line breaks * Update _includes/js/queries.md Co-Authored-By: Tom Fox <tomfox@surprises.io> * Update _includes/js/queries.md Co-Authored-By: Tom Fox <tomfox@surprises.io> * simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865