Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserSubclass.become should return subclass #897

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

kzmeyao
Copy link
Contributor

@kzmeyao kzmeyao commented Aug 21, 2019

This is a follow-up to #756 to add the same functionality to become.

Let me know if there's anything I'm missing.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #897   +/-   ##
======================================
  Coverage    92.1%   92.1%           
======================================
  Files          54      54           
  Lines        5026    5026           
  Branches     1127    1127           
======================================
  Hits         4629    4629           
  Misses        397     397
Impacted Files Coverage Δ
src/ParseUser.js 83.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862c2f5...d8937c1. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@dplewis dplewis merged commit 3af83ea into parse-community:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants