Let the iOS SDK handle Delete ops when sent from the server #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
flovilmart
force-pushed
the
parse-server-1840
branch
from
badda10 to
b36714a
Compare
|
@nlutsenko any news on that? |
|
@flovilmart Thanks for contribute this repos. Anyway What's going on? @nlutsenko any update? |
tkhoa87
added a commit
to notabasement/Parse-SDK-iOS-OSX
that referenced
this pull request
Jun 30, 2017
* ParsePlatform/master: ⚡️ Release 1.15.0 (parse-community#1153) ⚡ Release 1.14.5 (parse-community#1152) Add withinPolygon to Query (parse-community#1150) Use getter instead accessing instance variable (parse-community#1026) Makes PFEncoder and PFDecoder public for LiveQuery (parse-community#1149) Let the iOS SDK handle Delete ops when sent from the server (parse-community#928) Outputing offending bundle in assert message. (parse-community#1000) Update documentation links (parse-community#1102) Swift 3 (parse-community#1145) Allowing to re-save installation if LDS is enabled (parse-community#1125) Removed or replaced the broken links in the README (parse-community#1141) update pod spec homepage (parse-community#1135) Update podspec link Update links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: parse-community/parse-server#1946
Original Issue: parse-community/parse-server#1840
In a nutshell:
When performing an unset in Cloud Code the client SDKs need to perform a fetch in order the synchronize their state which is redundant and can possibly break the SoC.
On parse.com, the bug is present, and the deleted key is not part of the response. No way to know what really happened on cloud code.
In parse-server, the server responds with a Delete op on the key.
When serializing the JSON response,
undefinedkeys are stripped out of the generated string.We could have replaced with
nullbut that would also require updates on both SDK's to properly handle nulls. and we don't really loveNSNullon iOS do we?