Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom objectIds #100

Merged
merged 14 commits into from
Mar 22, 2021
Merged

Allow custom objectIds #100

merged 14 commits into from
Mar 22, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 21, 2021

Add support for custom objectIds parse-community/parse-server#6177

Close #99

To enable set allowCustomObjectId = true, it’s false by default:

ParseSwift.initialize(applicationId: "applicationId",
                               clientKey: "clientKey",
                               masterKey: "masterKey",
                               serverURL: url,
                               allowCustomObjectId: true)
  • Add documentation
  • Add test cases
  • Fix bug with anonymous user becoming a real user and the authData sent to the server was incorrect
  • Add changelog entry
  • Prepare for 1.2.2 release

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #100 (07e47f0) into main (fa74a7c) will increase coverage by 0.29%.
The diff coverage is 81.60%.

❗ Current head 07e47f0 differs from pull request most recent head 5880325. Consider uploading reports for the commit 5880325 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   80.66%   80.96%   +0.29%     
==========================================
  Files          65       65              
  Lines        5411     5415       +4     
==========================================
+ Hits         4365     4384      +19     
+ Misses       1046     1031      -15     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser.swift 81.06% <78.26%> (+1.90%) ⬆️
...Authentication/Protocols/ParseAuthentication.swift 74.04% <84.00%> (+3.95%) ⬆️
Sources/ParseSwift/Parse.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Protocols/Objectable.swift 85.71% <100.00%> (+1.33%) ⬆️
Sources/ParseSwift/Storage/ParseFileManager.swift 89.39% <0.00%> (-0.76%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 76.42% <0.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 82.81% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa74a7c...5880325. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom objectId before saving
1 participant