Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowCustomObjectId #101

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Fix allowCustomObjectId #101

merged 5 commits into from
Mar 27, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 22, 2021

  • Fixed a bug when the allowCustomObjectId config was enabled that was adding the objectId to the url endpoint. Fix Custom objectId before saving #99
  • When allowCustomObjectId == true, the SDK will throw an error if objectId is missing
  • Doc nits

@cbaker6
Copy link
Contributor Author

cbaker6 commented Mar 22, 2021

@TomWFox do you think we should leave this open for a bit and see if we find any other nits in the docs?

http://parseplatform.org/Parse-Swift/api/index.html

@TomWFox
Copy link
Contributor

TomWFox commented Mar 22, 2021

Totally up to you!

@cbaker6 cbaker6 changed the title Document nits Fix allowCustomObjectId Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #101 (a79f9f2) into main (453ebdb) will decrease coverage by 0.13%.
The diff coverage is 90.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   80.96%   80.82%   -0.14%     
==========================================
  Files          65       65              
  Lines        5415     5480      +65     
==========================================
+ Hits         4384     4429      +45     
- Misses       1031     1051      +20     
Impacted Files Coverage Δ
...Swift/Authentication/Internal/ParseAnonymous.swift 100.00% <ø> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 74.61% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 92.98% <ø> (ø)
Sources/ParseSwift/Types/ParseGeoPoint.swift 98.27% <ø> (ø)
Sources/ParseSwift/API/API+Commands.swift 78.04% <44.44%> (-0.28%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 76.77% <91.66%> (+0.35%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 83.13% <93.54%> (+0.31%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 81.37% <93.54%> (+0.47%) ⬆️
Sources/ParseSwift/Protocols/Objectable.swift 87.50% <100.00%> (+1.78%) ⬆️
Sources/ParseSwift/Storage/ParseFileManager.swift 81.81% <0.00%> (-8.34%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453ebdb...a79f9f2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom objectId before saving
2 participants