Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Microsoft OAuth Documentation #698

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Adding Microsoft OAuth Documentation #698

merged 1 commit into from
Jan 9, 2020

Conversation

alann-maulana
Copy link
Contributor

Referring #692 from @TomWFox

@alann-maulana
Copy link
Contributor Author

I'm curious why this assets/js/bundle.js included automatically? Is this my mistake, again? 😅

@dplewis
Copy link
Member

dplewis commented Dec 19, 2019

You don’t have to worry about that. When the PR is merged the bundle will be regenerated anyway

@alann-maulana
Copy link
Contributor Author

You don’t have to worry about that. When the PR is merged the bundle will be regenerated anyway

@dplewis ahh great, because suddenly I'm closing this PR #697 because of assets/js/bundle.js accidentally included at my commit

@dplewis
Copy link
Member

dplewis commented Dec 19, 2019

You can just leave. Look at previous PRs they all include it.

@dplewis
Copy link
Member

dplewis commented Dec 19, 2019

Nvm I wondered why this PR looked familiar.

TomWFox
TomWFox approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, sorry for the delay, looks good to me!

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

Merging as 3.10 has been released.

@TomWFox TomWFox merged commit cc489df into parse-community:gh-pages Jan 9, 2020
mtrezza added a commit to mtrezza/docs that referenced this pull request Jan 9, 2020
@mtrezza
Merge commit 'cc489df4a3d8544a52148c079ecaee3d1762108d' into gh-pages
d425b11 
* commit 'cc489df4a3d8544a52148c079ecaee3d1762108d':
  Adding microsoft oauth doc (parse-community#698)
  Encrypting Current User and Local Storage (parse-community#695)
  Update live-query.md (parse-community#696)
  Update config.md (parse-community#689)
  Fix User Subclass Documentation (parse-community#690)
  remove info about parse.com compatibility (parse-community#686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWFox TomWFox TomWFox approved these changes

Assignees
No one assigned
Labels
docs:server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alann-maulana @dplewis @TomWFox