Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): increase node version in docker to 12 #1788

Merged
merged 1 commit into from
Sep 8, 2021
Merged

feat(docker): increase node version in docker to 12 #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Add multi-factor authentication to dashboard login. To use one-time password, run `parse-dashboard --createMFA` or `parse-dashboard --createUser`. (Daniel Blyth) [#1624](https://github.com/parse-community/parse-dashboard/pull/1624)

## Improvements
- Docker image use now node 12 version [#1788](https://github.com/parse-community/parse-dashboard/pull/1788)
- CI now pushes docker images to Docker Hub (Corey Baker) [#1781](https://github.com/parse-community/parse-dashboard/pull/1781)
- Add CI check to add changelog entry (Manuel Trezza) [#1764](https://github.com/parse-community/parse-dashboard/pull/1764)
- Refactor: uniform issue templates across repos (Manuel Trezza) [#1767](https://github.com/parse-community/parse-dashboard/pull/1767)
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#
# --- Base Node Image ---
FROM node:8-alpine AS base
FROM node:12-alpine AS base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one and the one below should probably use the node tag, lts-alpine instead of 12 directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, 12 builds, but lts doesn't. It may be something in the npm packages as this occurs with lts: https://github.com/netreconlab/parse-dashboard/runs/3545759058?check_suite_focus=true#step:7:378

Copy link
Member

@mtrezza mtrezza Sep 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci tests don't pass for node 16 because node-sass (also in the logs you linked) needs to be bumped it seems. maybe that's why? not sure which node version lts-alpine uses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci tests don't pass for node 16 because node-sass (also in the logs you linked) needs to be bumped it seems. maybe that's why?

Makes sense, should it be bumped in this PR?

Copy link
Member

@mtrezza mtrezza Sep 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, it seems to requires some code refactoring because this is a chain reaction where we need to bump webpack to 5 as well. To make dashboard officially Node 16 compatible will be an undertaking of its own.


RUN apk update; \
apk add git;
Expand All @@ -23,7 +23,7 @@ RUN npm run prepare && npm run build

#
# --- Production Image ---
FROM node:8-alpine AS release
FROM node:12-alpine AS release
WORKDIR /src

# Copy production node_modules
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"parse-dashboard": "./bin/parse-dashboard"
},
"engines": {
"node": ">=8.9"
"node": ">=12"
},
"main": "Parse-Dashboard/app.js",
"jest": {
Expand Down