Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace create-react-class with ES6 classes #1818

Merged
merged 5 commits into from
Oct 4, 2021
Merged

refactor: replace create-react-class with ES6 classes #1818

merged 5 commits into from
Oct 4, 2021

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Sep 26, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Rest of the app uses ES6 classes, the last of two components that were using create-react-class can be safely refactored to "native" class components.

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 26, 2021 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.

  • ⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.

@damianstasik damianstasik force-pushed the remove-create-react-class branch from 5fe55fb to 33e18d1 Compare September 26, 2021 14:05
@damianstasik damianstasik changed the title Replace create-react-class with ES6 classes refactor: replace create-react-class with ES6 classes Sep 26, 2021
@dblythy
Copy link
Member

dblythy commented Sep 28, 2021

Nice refactor! Can you commit package-lock as well?

@damianstasik
Copy link
Contributor Author

@dblythy package-lock was not updated by npm, because this exact version of create-react-class is being used by other package.

@mtrezza
Copy link
Member

mtrezza commented Oct 4, 2021

Is this ready for review?

@damianstasik
Copy link
Contributor Author

@mtrezza yes

mtrezza
mtrezza approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making Parse Dashboard 1 dependency lighter.

@mtrezza mtrezza merged commit b910729 into parse-community:master Oct 4, 2021
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 5, 2021
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Oct 9, 2021
@cycqitianwushuge
Merge branch 'source'
5c09465 
* source: (53 commits)
  chore(release): 3.2.1 [skip ci]
  chore(release): 3.2.1-beta.1 [skip ci]
  ci: fix prerelease labels
  chore(release): 3.2.1-alpha.1 [skip ci]
  fix: enabling context menu for read-only cells (parse-community#1844)
  docs: add info about --dev parameter (parse-community#1842)
  build: merge beta (parse-community#1841)
  build: merge alpha (parse-community#1840)
  docs: fix release changelog filename
  docs: reword changelog quote
  docs: fix changelog branch names (parse-community#1837)
  refactor: simplify reading dashboard config from a json file (parse-community#1828)
  ci: update release branch names
  chore(release): 3.2.0 [skip ci]
  feat: add ctrl + arrow key to jump to first/last cell; fix left/right key navigation with hidden columns (parse-community#1827)
  refactor: upgrade inquirer from 8.1.2 to 8.1.3 (parse-community#1829)
  refactor: upgrade otpauth from 7.0.5 to 7.0.6 (parse-community#1830)
  refactor: replace create-react-class with ES6 classes (parse-community#1818)
  refactor: replace query-string with URLSearchParams (parse-community#1819)
  docs: fix typo in refactor changelog entry
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damianstasik @dblythy @mtrezza @parseplatformorg @visualfanatic