-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow GraphIQL headers #1836
Conversation
Thanks for opening this pull request!
|
I will reformat the title to use the proper commit message syntax. |
This is not yet ready for review, right? |
@mtrezza it is ready for review, are you expecting something else? GraphIQL already supports headers so it's pretty simple to enable them. |
Great, will take a look! I was just asking because no review was requested but it seemed already finished. |
No worries, I understand you take on a lot across the repos so I’m always conscious not to be demanding and “request” you review my PRs. I appreciate you have a lot of commitments and will get to things when you can. If something isn’t ready, I’ll mark it as draft 😊 |
I am actually specifically looking for PRs to merge here to test and refine release automation. So whenever there is a PR ready for review, just feel free to request in any repo. You are making a good point regarding how we can use the draft state of PRs. Let me open an issue for discussion. |
@axelhildingson could you test this feature and see if it works as you suggested in #1834? |
🎉 This pull request has been released in version 3.3.0-alpha.1 |
# [3.3.0-beta.1](3.2.1-beta.1...3.3.0-beta.1) (2021-11-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
🎉 This change has been released in version 3.3.0-beta.1 |
# [3.3.0](3.2.1...3.3.0) (2022-01-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021)) * context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
🎉 This change has been released in version 3.3.0 |
New Pull Request Checklist
Issue Description
New GraphIQL viewer doesn't allow header configuration
Related issue: #1834
Approach
Adds header editor to GraphIQL
TODOs before merging