fix: saving relation column fails if class has required fields #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
sadakchap
approved these changes
Dec 2, 2021
mtrezza
approved these changes
Dec 5, 2021
4 tasks
mtrezza
changed the title
parseplatformorg
pushed a commit
that referenced
this pull request
Dec 5, 2021
# [3.3.0-alpha.17](3.3.0-alpha.16...3.3.0-alpha.17) (2021-12-05) ### Bug Fixes * saving relation column fails if class has required fields ([#1937](#1937)) ([c67db08](c67db08))
|
🎉 This change has been released in version 3.3.0-alpha.17 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 1, 2022
# [4.0.0-beta.1](3.3.0-beta.3...4.0.0-beta.1) (2022-01-01) ### Bug Fixes * bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([26c0dfa](26c0dfa)) * context menu in data browser not opening for cell of type number ([#1913](#1913)) ([fb0e3a9](fb0e3a9)) * opening filter menu in data browser leads to blank page ([#1958](#1958)) ([750e8b1](750e8b1)) * saving relation column fails if class has required fields ([#1937](#1937)) ([c67db08](c67db08)) * security upgrade qrcode from 1.4.4 to 1.5.0 ([#1930](#1930)) ([244e1bb](244e1bb)) ### Features * upgrade graphiql from 1.4.7 to 1.5.1 ([#1943](#1943)) ([ebb1f66](ebb1f66)) * upgrade graphql from 15.7.0 to 16.0.0 ([#1926](#1926)) ([7c94e51](7c94e51)) * upgrade parse from 3.3.1 to 3.4.0 ([#1942](#1942)) ([13a250e](13a250e)) ### BREAKING CHANGES * The minimum required Node.js version is 12.22.0. ([7c94e51](7c94e51)) * The required Node version was increased to >=12.20.0. ([ebb1f66](ebb1f66))
|
🎉 This change has been released in version 4.0.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 6, 2022
# [4.0.0](3.3.0...4.0.0) (2022-02-06) ### Bug Fixes * bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([26c0dfa](26c0dfa)) * context menu in data browser not opening for cell of type number ([#1913](#1913)) ([fb0e3a9](fb0e3a9)) * opening filter menu in data browser leads to blank page ([#1958](#1958)) ([750e8b1](750e8b1)) * saving relation column fails if class has required fields ([#1937](#1937)) ([c67db08](c67db08)) * security upgrade qrcode from 1.4.4 to 1.5.0 ([#1930](#1930)) ([244e1bb](244e1bb)) * various UI bugs (e.g. filter data browser, switch app, upload file) ([#2014](#2014)) ([785978e](785978e)) ### Features * upgrade graphiql from 1.4.7 to 1.5.1 ([#1943](#1943)) ([ebb1f66](ebb1f66)) * upgrade graphql from 15.7.0 to 16.0.0 ([#1926](#1926)) ([7c94e51](7c94e51)) * upgrade parse from 3.3.1 to 3.4.0 ([#1942](#1942)) ([13a250e](13a250e)) ### BREAKING CHANGES * The minimum required Node.js version is 12.22.0. ([7c94e51](7c94e51)) * The required Node version was increased to >=12.20.0. ([ebb1f66](ebb1f66))
|
🎉 This change has been released in version 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
If a Class has required columns along with relation columns. Upon clicking on the relation column for a row, as we're taken to the relation class, as the add row button is clicked to add row, after we enter the data and hit save button, we get the error Please enter all the required fields.
Approach
When the relation class opens via clicking on
view relationbutton in the parent class, the required field validation logic tries to fetch Class Name from the param. In thethis.props.paramsobject for relations, the className is still set to the Parent class's name.To resolve this, the class name is fetched from the
this.state.newObjectinstead as it contains the name of the class which is about to be saved.