fix: Incorrect date picker position in data browser filter dialog #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 9, 2023 18:31
Thanks for opening this pull request!
|
AshishBarvaliya
changed the title
Uffizzi Ephemeral Environment
|
|
Is this ready for review? |
mtrezza
changed the title
mtrezza
changed the title
parseplatformorg
pushed a commit
that referenced
this pull request
May 27, 2023
# [5.2.0-alpha.4](5.2.0-alpha.3...5.2.0-alpha.4) (2023-05-27) ### Bug Fixes * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
|
🎉 This change has been released in version 5.2.0-alpha.4 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 10, 2023
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
|
🎉 This change has been released in version 5.2.0-beta.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 15, 2023
# [5.2.0](5.1.0...5.2.0) (2023-09-15) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) * Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839)) * Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b)) * Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
|
🎉 This change has been released in version 5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
After applying the filters, the placement of the date picker is changing.
Closes: #2424
Approach
After resolving the position issue, I proceeded to test the functionality with multiple datepickers. and discover a new overlapping issue.
Solution -
It appears that the current implementation of "setFocus" in FilterRow Component is being used to focus filter fields. But it should not focus the fields when the filters are active as It leads to above issue.
To address this issue, I propose modifying the implementation of "setFocus" to only focus on the field when it is in edit mode. I have added an "editmode" state to determine when the field is in edit mode, and I have also optimized(memonized) the component to prevent unnecessary re-rendering of "setFocus".