Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Class Level Permissions dialog throws error TypeError: ce.current is null for newly created class #2549

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: Class Level Permissions dialog throws error TypeError: ce.current is null for newly created class #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca137a7
fix: change the condition of render SecurityDialog to prevent error o…
devbymak Apr 24, 2024
336980a
fix: update CLPs state on create and drop class
devbymak Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dashboard/Data/Browser/Browser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ class Browser extends DashboardView {
this.props.schema
.dispatch(ActionTypes.CREATE_CLASS, { className })
.then(() => {
this.state.clp[className] = this.props.schema.data.get('CLPs').toJS()[className];
this.state.counts[className] = 0;
this.props.navigate(generatePath(this.context, 'browser/' + className));
})
Expand All @@ -380,6 +381,7 @@ class Browser extends DashboardView {
this.props.schema.dispatch(ActionTypes.DROP_CLASS, { className }).then(
() => {
this.setState({ showDropClassDialog: false });
delete this.state.clp[className];
delete this.state.counts[className];
this.props.navigate(generatePath(this.context, 'browser'));
},
Expand Down
2 changes: 1 addition & 1 deletion src/dashboard/Data/Browser/BrowserToolbar.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ const BrowserToolbar = ({
disabled={isPendingEditCloneRows}
/>
{onAddRow && <div className={styles.toolbarSeparator} />}
{perms && enableSecurityDialog ? (
{enableSecurityDialog ? (
<SecurityDialog
ref={clpDialogRef}
disabled={!!relation || !!isUnique}
Expand Down
Loading