Fix calendar month/current selection and clicking #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nversion for currentMonth
…ne to match props.local
|
By analyzing the blame information on this pull request, we identified @drew-gross to be a potential reviewer. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
georgeloh
added a commit
to georgeloh/parse-dashboard
that referenced
this pull request
Oct 19, 2016
* master: Added support for trusting proxies w/ HTTPS (parse-community#535) Fix calendar month/current selection and clicking (parse-community#555) Fix text in CONTRIBUTING.md (parse-community#533) Adds an "ends with" filter for string queries (parse-community#540) Fix documentation link and open link in new browser tab. (parse-community#534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in DateUtils uses local time (e.g. getMonth() instead of getUTCMonth() etc.) so for compatibility state.currentMonth is also now considered local time.
props.local is used in only 2 places:
There is no code path where props.local is true so this has not been tested. I can't think why this would be required so would like to remove in a non-bugfix PR.
Have tested in timezones UTC+1, UTC-12, UTC+14 (in which case local time was one day after UTC)