Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_PushStatus add to SpecialClasses #701

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

gimdongwoo
Copy link
Contributor

I love parse-server & parse-dashboard.

I have found that the _PushStatus class is specially handled, but that's the definition is missing.

It's a simple changes, but I'm glad to be able to send PR to parse-dashboard.

Thank you!

@natanrolnik
Copy link
Contributor

@gimdongwoo thanks for your contribution!
What's the result in the Dashboard for having _PushStatus as a special class? It shows by default in the available classes in the menu?

If so, I'm not sure that this is something desired, considering that we can have the Push section in the menu as well, that shows the _PushStatus in a better way.

@gimdongwoo
Copy link
Contributor Author

gimdongwoo commented May 7, 2017

Yes, _PushStatus is exposed by default.
2017-05-07 3 37 59

Of course, you can also see it on the Push tab.
2017-05-07 3 39 42
But this is not searchable, it's difficult to handle push results as meaningful data.

It's better way to give it a special name 'PushStatus', such as _User, _Installation, _Session, etc.

@flovilmart
Copy link
Contributor

I'm not sure it's really something we want to be exposed like that, perhaps we could have a 'browser' view into the Past Pushes instead of adding the _PushStatus to the tables. _PushStatus is an internal table that is not managed by the user. This should be read only, even for the masterKey.

@gimdongwoo
Copy link
Contributor Author

It's already exposed basically,
rather than being exposed as like a bug named _PushStatus, I thought it was right to give it a name.

For those exposed as accessible classes, I thought it seems better way to have the PushStatus exposed, like Session or Installation is exposed.

@natanrolnik
Copy link
Contributor

I actually think we could have them displayed in the Dashboard, for easier querying, and having all the fields with edit disabled, read only.

@flovilmart what do you think?
@gimdongwoo do you think that would be possible to do?

@flovilmart
Copy link
Contributor

Alright let's go! I actually had to query in it recently, so that's a nice addition!

@flovilmart flovilmart merged commit d1d71a5 into parse-community:master Nov 25, 2017
@gimdongwoo
Copy link
Contributor Author

@flovilmart Thank you. It's my honor 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants