Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Release 1.1.2 #794

Merged
merged 3 commits into from
Oct 27, 2017
Merged

⚡ Release 1.1.2 #794

merged 3 commits into from
Oct 27, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Oct 27, 2017

  • Reverts the GreenKeeper update.
  • Fixes an issue affecting the read-only users.
  • Bumps version for immediate release.

@flovilmart flovilmart changed the title Fix master ⚡ Release 1.1.2 Oct 27, 2017
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Just to check, this rolls back a select group of changes from 1.1.1 with a few additional fixes for the issues mentioned?

@flovilmart
Copy link
Contributor Author

The 1st commit is the rollback of the deps updates (which is causing all hell breaking loose).
The 2nd commit is a hot fix (that ensuring config.apps is not mutated)
The 3rd commit is just the version bump.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, if there's nothing else that should be checked we can go ahead and move this along 👍 .

We'll still want to make dependency updates at some point, albeit selectively.

@flovilmart
Copy link
Contributor Author

Yeah react-router is breaking everything from 2 to 4, that's the big bad boy, perhaps we should try to bump everything but this one.

@flovilmart flovilmart merged commit 66d087e into master Oct 27, 2017
@flovilmart flovilmart deleted the fix-master branch October 27, 2017 17:21
@montymxb
Copy link
Contributor

If the break is incredibly evident than we could either modify the tests to catch it, or just run through it ourselves to verify the dashboard still functions as expected. I would love to have a test that could potentially catch this however, just so it's automated.

@montymxb
Copy link
Contributor

montymxb commented Oct 27, 2017

One more thing, I'm presuming this will rectify the docker build issue?

@flovilmart
Copy link
Contributor Author

Test would be quite complex to setup at this point but we could have a look from the broken commit. I assume docker should be fine

@ctrongminh
Copy link
Contributor

@flovilmart, you are so fast,

I was about to open a PR for the second commit (An issue introduced when using readOnlyMasterKey would make all users readOnly after one has logged in).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants