-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add background color in AppCard #838
add background color in AppCard #838
Conversation
Can you provide a screenshot? |
@dplewis Here! |
Thanks for getting started on this featured request! #681 Can you add the background color to the data browser? This is just an example. |
Thanks for your PR, @AreYouHappy . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, besides what I commented above, could you please add it to the Changelog and to Readme, below "App Icon Configuration"? Also, please don't forget to link it in the header of the readme.
In my side I’m not sure I’m convinced by the feature. |
@flovilmart It helps people like me with multiple servers. I can't count how many times I've changed production thinking it was on local. Adding colors would help. |
* Add background color in AppCard * add line to changelog
If the backgorundcolor is not entered, it is replaced with the default. ( It is CSS style) |
It’s not that it doesn’t look good it should be an indicator that a different server is being used. Changing the color of the app card is the same as looking at the URL. I would like to see something more semi-themed to avoid confusion. |
Hmm .. I don't have good sense of design. |
@AreYouHappy You could have a |
…ard (parse-community#838) * Add primaryBackgroundColor and secondaryBackgroundColor color color in AppCard * add line to changelog
Would you try it? |
@AreYouHappy Thanks for the update. I'll have some time today to try it out! |
@@ -4,7 +4,8 @@ | |||
"appId": "", | |||
"masterKey": "", | |||
"appName": "", | |||
"iconName": "" | |||
"iconName": "", | |||
"backgroundColor":"#000000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change background color here to primary and secondary defaults?
@AreYouHappy Just tried it out and it works great. Just a small change. Defaults are working without adding these fields. |
I changed it as follows. |
@natanrolnik How does this look? |
@dplewis I understand the need, and in my opinion, it's good: we still have the default version, and whoever wants to customize, it's his/her responsibility to do so. Where are the primary and secondary colors applied, in the end? |
@natanrolnik In the app cards and databrowser. The above attached images. |
Thanks @AreYouHappy and @dplewis. |
add background color
Easily distinguish your app cards.