Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add background color in AppCard #838

Merged
merged 4 commits into from
Mar 6, 2018

Conversation

bugtype
Copy link
Contributor

@bugtype bugtype commented Feb 15, 2018

add background color

Easily distinguish your app cards.

{
  "apps": [{
    "serverURL": "",
    "appId": "",
    "masterKey": "",
    "appName": "",
    "iconName": "",
    "backgroundColor":"#000000"
  }],
  "iconsFolder": "icons"
}

@dplewis
Copy link
Member

dplewis commented Feb 15, 2018

Can you provide a screenshot?

@bugtype
Copy link
Contributor Author

bugtype commented Feb 15, 2018

@dplewis Here!

2018-02-16 7 39 27

@dplewis
Copy link
Member

dplewis commented Feb 15, 2018

Thanks for getting started on this featured request! #681

Can you add the background color to the data browser? This is just an example.

36285572-b8474e58-1271-11e8-9c76-b5b45f6a3968

@bugtype
Copy link
Contributor Author

bugtype commented Feb 16, 2018

2018-02-16 12 44 45

2018-02-16 12 44 51

2018-02-16 12 47 27

Hmm ... I do not recommend it.

@natanrolnik
Copy link
Contributor

Thanks for your PR, @AreYouHappy .
If no value is configured, what value is used? Can you make a condition that, if backgroundColor isn't set, or if it's set to an empty string, it is not used?

Copy link
Contributor

@natanrolnik natanrolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, besides what I commented above, could you please add it to the Changelog and to Readme, below "App Icon Configuration"? Also, please don't forget to link it in the header of the readme.

@flovilmart
Copy link
Contributor

In my side I’m not sure I’m convinced by the feature.

@dplewis
Copy link
Member

dplewis commented Feb 17, 2018

@flovilmart It helps people like me with multiple servers. I can't count how many times I've changed production thinking it was on local. Adding colors would help.

* Add background color in AppCard

* add line to changelog
@bugtype
Copy link
Contributor Author

bugtype commented Feb 17, 2018

If the backgorundcolor is not entered, it is replaced with the default. ( It is CSS style)
The colors at Data brower don't look good and aren't in now.
Please let me know if you have a problem with that commit!
Thank you for your feedback.

@dplewis
Copy link
Member

dplewis commented Feb 17, 2018

It’s not that it doesn’t look good it should be an indicator that a different server is being used.

Changing the color of the app card is the same as looking at the URL.

I would like to see something more semi-themed to avoid confusion.

@bugtype
Copy link
Contributor Author

bugtype commented Feb 17, 2018

Hmm .. I don't have good sense of design.
Do you want the Data browser part to change color, too?
[1] Core part
[2] Classes part (Browser)
I'm concerned about how to make the difference between [1] and [2] colors.
Do you have any good ideas?

@dplewis
Copy link
Member

dplewis commented Feb 19, 2018

@AreYouHappy You could have a primaryBackgroundColor and secondaryBackgroundColor with defaults for both.

…ard (parse-community#838)

* Add primaryBackgroundColor and secondaryBackgroundColor color color in AppCard

* add line to changelog
@bugtype
Copy link
Contributor Author

bugtype commented Feb 24, 2018

Would you try it?

@dplewis
Copy link
Member

dplewis commented Feb 26, 2018

@AreYouHappy Thanks for the update. I'll have some time today to try it out!

@@ -4,7 +4,8 @@
"appId": "",
"masterKey": "",
"appName": "",
"iconName": ""
"iconName": "",
"backgroundColor":"#000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change background color here to primary and secondary defaults?

@dplewis
Copy link
Member

dplewis commented Mar 1, 2018

@AreYouHappy Just tried it out and it works great. Just a small change.

Defaults are working without adding these fields.

@bugtype
Copy link
Contributor Author

bugtype commented Mar 1, 2018

{
  "apps": [{
    "serverURL": "",
    "appId": "",
    "masterKey": "",
    "appName": "",
    "iconName": "",
    "primaryBackgroundColor": "",
    "secondaryBackgroundColor": ""
  }],
  "iconsFolder": "icons"
}

I changed it as follows.

@dplewis
Copy link
Member

dplewis commented Mar 1, 2018

@natanrolnik How does this look?

@natanrolnik
Copy link
Contributor

@dplewis I understand the need, and in my opinion, it's good: we still have the default version, and whoever wants to customize, it's his/her responsibility to do so. Where are the primary and secondary colors applied, in the end?

@dplewis
Copy link
Member

dplewis commented Mar 6, 2018

@natanrolnik In the app cards and databrowser. The above attached images.

@natanrolnik natanrolnik merged commit dba2191 into parse-community:master Mar 6, 2018
@natanrolnik
Copy link
Contributor

natanrolnik commented Mar 6, 2018

Thanks @AreYouHappy and @dplewis.
Release 1.2.0 is already available 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants