-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distinct / unique filter #920
Conversation
@flovilmart @acinader Quick update Add / Delete rows are disabled if filtering by unique. All fields are readonly It works for all fields except arrays. Discussed here parse-community/parse-server#4195 (comment) I could also add not unique filter, discussed here parse-community/parse-server#5019 This haven't been tested on Postgres |
Can you quickly test over on Postgres? Worst case add a flag on parse server features |
@flovilmart A quick fix for PG and everything works |
@natanrolnik what do you think? Not well versed in this area ;) |
@flovilmart sorry the late reply. |
@natanrolnik What would you like to see? |
Looks good. My only comment: From what I see here, the “Add a column” button is still enabled. Do you think it makes sense to disable it? I think it does. |
Yeah, I wanted your advice on that. I can remove it |
@natanrolnik @flovilmart I just tried this against a Collection with 305k unique records (_Session, expiresAt field) and received a 504 (Gateway Timeout). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@dplewis what do you want to wit this? |
@acinader Waiting for review. I did find that on large datasets this can cause a timeout, if you haven't set timeout / index the field. |
what do you think about that? |
A popup box with a warning or wait until indexes get added to dashboard |
can you catch the timeout? |
After updating my server config maxTimeMS I don't get that timeout error. |
The label |
Closes: #888
I don't really know the conventions for react, so any help would be appreciated.
More testing will be needed as I may have missed something.