Support object->exists() #453
Conversation
There was a problem hiding this comment.
I think this should more closely match the js version
https://github.com/parse-community/Parse-SDK-JS/blob/master/src/ParseObject.js#L948-L962
src/Parse/ParseObject.php
Outdated
| public function exists($useMasterKey = false) | ||
| { | ||
| if (!$this->objectId) { | ||
| return; |
There was a problem hiding this comment.
I think this should match the js sdk more closely?
https://github.com/parse-community/Parse-SDK-JS/blob/master/src/ParseObject.js#L948-L962
src/Parse/ParseObject.php
Outdated
| $query->get($this->objectId, $useMasterKey); | ||
| return true; | ||
| } catch (Exception $e) { | ||
| if ($e->getMessage() === 'Object not found.') { |
There was a problem hiding this comment.
can this test the error code or number instead of the message string?
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
============================================
- Coverage 98% 97.97% -0.03%
- Complexity 1058 1062 +4
============================================
Files 39 39
Lines 2950 2960 +10
============================================
+ Hits 2891 2900 +9
- Misses 59 60 +1
Continue to review full report at Codecov.
|
No description provided.